Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 22124002: Settings: Make 'edit' button in autofill setting not mouse-focusable. (Closed)

Created:
7 years, 4 months ago by tkent
Modified:
7 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, Raman Kakilate, benquan, ahutter, arv+watch_chromium.org, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org, Dane Wallinga
Visibility:
Public.

Description

Settings: Make 'edit' button in autofill setting not mouse-focusable. This fixes a regression by Blink r153039. We should not focus on "Edit" button in autofill setting by mouse press. We call preventDefault() in mousedown event handler of the button. BUG=268031 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/options/autofill_options_list.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Erik, would you review this please?
7 years, 4 months ago (2013-08-05 00:20:47 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-05 13:42:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/22124002/1
7 years, 4 months ago (2013-08-06 00:38:55 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 05:58:56 UTC) #4
Message was sent while issue was closed.
Change committed as 215809

Powered by Google App Engine
This is Rietveld 408576698