Issue 22124002: Settings: Make 'edit' button in autofill setting not mouse-focusable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22124002: Settings: Make 'edit' button in autofill setting not mouse-focusable. (Closed)

Created:
7 years, 4 months ago by tkent

Modified:
7 years, 4 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, dbeam+watch-options_chromium.org, Raman Kakilate, benquan, ahutter, arv+watch_chromium.org, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org, Dane Wallinga

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Settings: Make 'edit' button in autofill setting not mouse-focusable. This fixes a regression by Blink r153039. We should not focus on "Edit" button in autofill setting by mouse press. We call preventDefault() in mousedown event handler of the button. BUG=268031 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215809

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/resources/options/autofill_options_list.js	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/22124002/1

7 years, 4 months ago (2013-08-06 00:38:55 UTC) #3

Message was sent while issue was closed.

Change committed as 215809

Expand Messages | Collapse Messages