Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 221233005: Remove remaining Dart-specific perl code in Dartium (Closed)

Created:
6 years, 8 months ago by vsm
Modified:
6 years, 8 months ago
Reviewers:
terry, Jacob, siva
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove msvs setting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -734 lines) Patch
M Source/bindings/dart/gyp/dartium.gyp View 1 5 chunks +3 lines, -43 lines 0 comments Download
D Source/bindings/dart/gyp/scripts/EventNames.in View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/bindings/dart/gyp/scripts/Hasher.pm View 1 chunk +0 lines, -93 lines 0 comments Download
D Source/bindings/dart/gyp/scripts/InFilesCompiler.pm View 1 chunk +0 lines, -182 lines 0 comments Download
D Source/bindings/dart/gyp/scripts/InFilesParser.pm View 1 chunk +0 lines, -154 lines 0 comments Download
D Source/bindings/dart/gyp/scripts/StaticString.pm View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/bindings/dart/gyp/scripts/make_header.pl View 1 chunk +0 lines, -110 lines 0 comments Download
D Source/bindings/dart/gyp/scripts/xxd.pl View 1 chunk +0 lines, -45 lines 0 comments Download
M Source/build/scripts/name_macros.py View 2 chunks +13 lines, -5 lines 0 comments Download
M Source/core/core_generated.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vsm
6 years, 8 months ago (2014-04-01 18:20:00 UTC) #1
vsm
Remove msvs setting
6 years, 8 months ago (2014-04-01 18:27:45 UTC) #2
Jacob
Nice! lgtm
6 years, 8 months ago (2014-04-01 18:32:02 UTC) #3
siva
Nice.
6 years, 8 months ago (2014-04-01 18:42:56 UTC) #4
vsm
6 years, 8 months ago (2014-04-01 18:46:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r170594 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698