Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: content/browser/bluetooth/bluetooth_device_chooser_controller.cc

Issue 2210873003: bluetooth: Allow updates on chooser items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-fix-advertised-services
Patch Set: Make const Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/bluetooth_device_chooser_controller.cc
diff --git a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
index 6d02f2355b3ab301570a64869e6df36759e65f8f..7986f72a8ceb1c9035b8cffcc8b4dffa1b3e5e3a 100644
--- a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
+++ b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
@@ -340,7 +340,14 @@ void BluetoothDeviceChooserController::AddFilteredDevice(
const device::BluetoothDevice& device) {
if (chooser_.get() && MatchesFilters(device, options_->filters)) {
VLOG(1) << "Adding device to chooser: " << device.GetAddress();
- chooser_->AddDevice(device.GetAddress(), device.GetNameForDisplay());
+ chooser_->AddOrUpdateDevice(
+ device.GetAddress(),
+ // TODO(https://crbug.com/634366): Update device's name when necessary.
+ false /* should_update_name */, device.GetNameForDisplay(),
+ // TODO(http://crbug.com/543466): Show connection and paired status.
+ false /* is_gatt_connected */, false /* is_paired */,
+ // TODO(http://crbug.com/629689): Add signal strength indicator.
+ nullptr /* rssi */);
}
}
« no previous file with comments | « chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.cc ('k') | content/public/browser/bluetooth_chooser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698