Issue 22108002: Have all the rebaseline commands only rebaseline failures that are actually happening on the bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22108002: Have all the rebaseline commands only rebaseline failures that are actually happening on the bots. (Closed)

Created:
7 years, 4 months ago by ojan

Modified:
7 years, 4 months ago

Reviewers:
Dirk Pranke

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have all the rebaseline commands only rebaseline failures that are actually happening on the bots. At first, I thought this only made sense for auto-rebaseline, but I think it never makes sense to try to do a rebaseline for a failure that isn't happening on the bots. This fixes the bug where rebaselining will always grab the flaky result because it grabs whatever's in the accumulated results directory Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155897

Patch Set 1 #

Patch Set 2 : merge to tot #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -59 lines)			Patch
	M	Tools/Scripts/webkitpy/tool/commands/rebaseline.py	View		7 chunks	+26 lines, -24 lines	0 comments	Download
	M	Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py	View		6 chunks	+110 lines, -35 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ojan

No worries. I wasn't blocked or anything. On Fri, Aug 9, 2013 at 5:14 PM, ...

7 years, 4 months ago (2013-08-10 00:15:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/22108002/2001

7 years, 4 months ago (2013-08-10 00:16:41 UTC) #5

Message was sent while issue was closed.

Change committed as 155897

Expand Messages | Collapse Messages