Ignore unused classes when constructing set for deferred loading.

sdk/lib/_internal/compiler/implementation/deferred_load.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library deferred_load;
 
 import 'dart:collection'
        show LinkedHashMap,
             LinkedHashSet;
 
@@ skipping 135 matching lines @@
       // When instantiating a class, we record a reference to the
       // constructor, not the class itself.  We must add all the
       // instance members of the constructor's class (see below).
       result.addAll(
           allElementsResolvedFrom(element.getEnclosingClass().implementation));
     }
     if (element.isClass()) {
       // If we see a class, add everything its instance members refer
       // to.  Static members are not relevant.
       ClassElement cls = element.declaration;
-      cls.forEachLocalMember((Element e) {
-        if (!e.isInstanceMember()) return;
-        result.addAll(DependencyCollector.collect(e.implementation, compiler));
-      });
-      if (cls.implementation != cls) {
-        // TODO(ahe): Why doesn't ClassElement.forEachLocalMember do this?
-        cls.implementation.forEachLocalMember((Element e) {
+      // Make sure that class has been used - type has been computed.
+      if (cls.thisType != null) {

[ahe, 2013/08/06 16:00:34]

I think this check belongs on line 92, and it feels like it should be a little
more general. Something like a method in Enqueuer:

bool isLive(Element element) {
  if (seenClasses.contains(element)) return true;
  if (getCachedElements(element) != null) return true;
  return false;
}

[aam-me, 2013/08/07 03:20:42]

Thanks, makes sense.
Done.

+        cls.forEachLocalMember((Element e) {
           if (!e.isInstanceMember()) return;
-          result.addAll(DependencyCollector.collect(e.implementation,
-                                                    compiler));
+          result.addAll(DependencyCollector.collect(e.implementation, compiler));
         });
+        if (cls.implementation != cls) {
+          // TODO(ahe): Why doesn't ClassElement.forEachLocalMember do this?
+          cls.implementation.forEachLocalMember((Element e) {
+            if (!e.isInstanceMember()) return;
+            result.addAll(DependencyCollector.collect(e.implementation,
+                                                      compiler));
+          });
+        }
+        for (var type in cls.allSupertypes) {
+          result.add(type.element.implementation);
+        }
+        result.add(cls.implementation);
       }
-      for (var type in cls.allSupertypes) {
-        result.add(type.element.implementation);
-      }
-      result.add(cls.implementation);
     } else if (Elements.isStaticOrTopLevel(element)
                || element.isConstructor()) {
       result.addAll(DependencyCollector.collect(element, compiler));
     }
     // Other elements, in particular instance members, are ignored as
     // they are processed as part of the class.
     return result;
   }
 
   void addTransitiveClosureTo(Set<Element> elements) {
@@ skipping 60 matching lines @@
         compiler.enqueuer.resolution.getCachedElements(element);
     if (elements == null) return new LinkedHashSet<Element>();
     Node node = element.parseNode(compiler);
     if (node == null) return new LinkedHashSet<Element>();
     var collector = new DependencyCollector(elements, compiler);
     node.accept(collector);
     collector.dependencies.addAll(elements.otherDependencies);
     return collector.dependencies;
   }
 }