Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issue 22043004: Check for null on Browser pointer to address crash report. (Closed)

Created:
7 years, 4 months ago by annark1
Modified:
7 years, 4 months ago
Reviewers:
Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, beaudoin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adding null pointer check on Browser pointer in InstantPage::MaybeRemoveMostVisitedItems. BUG=267844 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/search/instant_page.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
annark1
Hi Jered, PTAL, addressing crash report. Thanks, Anna
7 years, 4 months ago (2013-08-05 17:12:11 UTC) #1
Jered
On 2013/08/05 17:12:11, annark1 wrote: > Hi Jered, > > PTAL, addressing crash report. > ...
7 years, 4 months ago (2013-08-06 09:40:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/annark@chromium.org/22043004/1
7 years, 4 months ago (2013-08-06 12:03:09 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 17:26:15 UTC) #4
Message was sent while issue was closed.
Change committed as 215921

Powered by Google App Engine
This is Rietveld 408576698