Rename BrowserThread::IsWellKnownThread to IsThreadInitialized.

Rename BrowserThread::IsWellKnownThread to IsThreadInitialized.

This name is a better description of what this function does.

Also, IsThreadInitialized now DCHECKS if identifier is out of enum range,
instead of returning false.

BUG=268212
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216931

[Matt Giuca, 2013-08-05 01:31:16]

Either joth or brettw: If interested (since you changed this function most
recently).
sky: content/browser/browser_thread_impl.cc
     and mechanical changes on all of the chrome/browser/* files.
     (Should not require individual owners to approve, since it is just a
rename.)
joi: content/public/browser/browser_thread.h

https://codereview.chromium.org/22031003/diff/2009/content/browser/browser_th...
File content/browser/browser_thread_impl.cc (right):

https://codereview.chromium.org/22031003/diff/2009/content/browser/browser_th...
content/browser/browser_thread_impl.cc:348: DCHECK(identifier >= 0 && identifier
< ID_COUNT);
I changed this because if |identifier| is not a valid enum value, that is a
programming error which should DCHECK, not merely a false condition.

All call sites pass a literal enum value, so this should not change the current
behaviour at all.

[brettw, 2013-08-05 23:34:26]

lgtm

[Matt Giuca, 2013-08-07 04:53:22]

sky and joi are both on vacation, and I just noticed that brettw you are in
OWNERS of all of content/*. Can I take your LGTM as OWNERS approval for both
content/public/browser/browser_thread.h and
content/browser/browser_thread_impl.cc?

jhawkins: Can you give OWNERS approval for all of the mechanical (method call
rename) changes in chrome/*? (Not sure if I should TBR all of the individual
module owners or if it's so trivial a change that it doesn't matter.)

[James Hawkins, 2013-08-08 00:25:46]

https://codereview.chromium.org/22031003/diff/25001/content/public/browser/br...
File content/public/browser/browser_thread.h (right):

https://codereview.chromium.org/22031003/diff/25001/content/public/browser/br...
content/public/browser/browser_thread.h:182: // Callable on any thread.  Returns
whether the given well-known thread has
Optional nit: s/has been/is/

[James Hawkins, 2013-08-08 00:25:59]

Sorry, that was "LGTM with optional nit."

[Matt Giuca, 2013-08-08 04:09:47]

brettw: Ping to make sure it's okay to take your lgtm as OWNERS approval on
content/*.

https://codereview.chromium.org/22031003/diff/25001/content/public/browser/br...
File content/public/browser/browser_thread.h (right):

https://codereview.chromium.org/22031003/diff/25001/content/public/browser/br...
content/public/browser/browser_thread.h:182: // Callable on any thread.  Returns
whether the given well-known thread has
On 2013/08/08 00:25:46, James Hawkins wrote:
> Optional nit: s/has been/is/

Done.

[brettw, 2013-08-09 19:50:43]

Yeah, content looks OK.

[commit-bot: I haz the power, 2013-08-12 00:24:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/22031003/34001

[commit-bot: I haz the power, 2013-08-12 05:20:34]

Change committed as 216931