Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/core/fetch/FontResource.cpp

Issue 2202173002: Refactoring: Make Resource::m_data private (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address on hiroshige's review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/FontResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/FontResource.cpp b/third_party/WebKit/Source/core/fetch/FontResource.cpp
index 0684def41af36d4a131c456b2748b73b1bbd2e8c..c0b615f73b8a3e6b02bb7dd802aeb09bc09f2c2f 100644
--- a/third_party/WebKit/Source/core/fetch/FontResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/FontResource.cpp
@@ -121,11 +121,11 @@ void FontResource::startLoadLimitTimersIfNeeded()
bool FontResource::ensureCustomFontData()
{
if (!m_fontData && !errorOccurred() && !isLoading()) {
- if (m_data)
- m_fontData = FontCustomPlatformData::create(m_data.get(), m_otsParsingMessage);
+ if (data())
+ m_fontData = FontCustomPlatformData::create(data(), m_otsParsingMessage);
if (m_fontData) {
- recordPackageFormatHistogram(packageFormatOf(m_data.get()));
+ recordPackageFormatHistogram(packageFormatOf(data()));
} else {
setStatus(DecodeError);
recordPackageFormatHistogram(PackageFormatUnknown);
@@ -142,7 +142,7 @@ FontPlatformData FontResource::platformDataFromCustomData(float size, bool bold,
bool FontResource::isSafeToUnlock() const
{
- return m_data->hasOneRef();
+ return data()->hasOneRef();
}
void FontResource::fontLoadShortLimitCallback(TimerBase*)
« no previous file with comments | « third_party/WebKit/Source/core/fetch/DocumentResource.cpp ('k') | third_party/WebKit/Source/core/fetch/ImageResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698