Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 22014002: Rename onSuccess to callback in setShouldPollCards and setToastVisible (Closed)

Created:
7 years, 4 months ago by robliao
Modified:
7 years, 4 months ago
Reviewers:
xiyuan, vadimt
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@SMLog
Visibility:
Public.

Description

Rename onSuccess to callback in setShouldPollCards and setToastVisible BUG=164227 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/resources/google_now/background.js View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
robliao
7 years, 4 months ago (2013-08-03 01:27:12 UTC) #1
vadimt
lgtm
7 years, 4 months ago (2013-08-03 01:40:36 UTC) #2
robliao
xiyuan: Please provide owner approval for this CL. Thanks!
7 years, 4 months ago (2013-08-05 17:12:26 UTC) #3
xiyuan
lgtm
7 years, 4 months ago (2013-08-05 18:41:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/22014002/1
7 years, 4 months ago (2013-08-05 18:43:45 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-05 18:51:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/22014002/1
7 years, 4 months ago (2013-08-05 19:00:36 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 01:00:31 UTC) #8
Message was sent while issue was closed.
Change committed as 215751

Powered by Google App Engine
This is Rietveld 408576698