components/autofill/core/browser/webdata/autofill_table.cc - Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_table.cc

Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/phone_number_unittest.cc ('k') | components/webdata/common/web_database_migration_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_table.cc

diff --git a/components/autofill/core/browser/webdata/autofill_table.cc b/components/autofill/core/browser/webdata/autofill_table.cc

index 07955b29ce45d754ec5b736b3ec430fba0955fc3..9066d9c0df0c8cf151f4d7f87bed3d2985e5d4ed 100644

--- a/components/autofill/core/browser/webdata/autofill_table.cc

+++ b/components/autofill/core/browser/webdata/autofill_table.cc

@@ -72,7 +72,7 @@ void BindAutofillProfileToStatement(const AutofillProfile& profile,

s->BindString16(5, LimitDataSize(text));

text = profile.GetRawInfo(ADDRESS_HOME_ZIP);

s->BindString16(6, LimitDataSize(text));

- text = profile.GetInfo(ADDRESS_HOME_COUNTRY, app_locale);

+ text = profile.GetInfo(AutofillType(ADDRESS_HOME_COUNTRY), app_locale);

s->BindString16(7, LimitDataSize(text));

text = profile.GetRawInfo(ADDRESS_HOME_COUNTRY);

s->BindString16(8, LimitDataSize(text));

@@ -1928,7 +1928,8 @@ bool AutofillTable::MigrateToVersion33ProfilesBasedOnFirstName() {

profile.SetRawInfo(ADDRESS_HOME_CITY, s.ColumnString16(8));

profile.SetRawInfo(ADDRESS_HOME_STATE, s.ColumnString16(9));

profile.SetRawInfo(ADDRESS_HOME_ZIP, s.ColumnString16(10));

- profile.SetInfo(ADDRESS_HOME_COUNTRY, s.ColumnString16(11), app_locale_);

+ profile.SetInfo(AutofillType(ADDRESS_HOME_COUNTRY), s.ColumnString16(11),

+ app_locale_);

profile.SetRawInfo(PHONE_HOME_WHOLE_NUMBER, s.ColumnString16(12));

int64 date_modified = s.ColumnInt64(13);

@@ -2151,7 +2152,7 @@ bool AutofillTable::MigrateToVersion37MergeAndCullOlderProfiles() {

s.BindString16(5, LimitDataSize(text));

text = iter->GetRawInfo(ADDRESS_HOME_ZIP);

s.BindString16(6, LimitDataSize(text));

- text = iter->GetInfo(ADDRESS_HOME_COUNTRY, app_locale_);

+ text = iter->GetInfo(AutofillType(ADDRESS_HOME_COUNTRY), app_locale_);

s.BindString16(7, LimitDataSize(text));

text = iter->GetRawInfo(ADDRESS_HOME_COUNTRY);

s.BindString16(8, LimitDataSize(text));