ash: Rename "Autohide launcher" item.

ash: Rename "Autohide launcher" item.

This patch renames:
- "Autohide launcher" to "Autohide shelf"
- "Launcher position" to "Shelf position".

BUG=263531
TEST=out_cros/Debug/chrome --disable-setuid-sandbox --ash-use-alternate-shelf --show-launcher-alignment-menu
R=jamescook@chromium.org,sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215808

[tfarina, 2013-08-03 02:33:56]

https://codereview.chromium.org/22007003/diff/1/ash/launcher/launcher_alignme...
File ash/launcher/launcher_alignment_menu.cc (left):

https://codereview.chromium.org/22007003/diff/1/ash/launcher/launcher_alignme...
ash/launcher/launcher_alignment_menu.cc:17: aura::RootWindow* root)
all these formatting changes was clang-format, not me doing manually.

[xiyuan, 2013-08-03 04:44:40]

https://codereview.chromium.org/22007003/diff/1/ash/launcher/launcher_alignme...
File ash/launcher/launcher_alignment_menu.cc (left):

https://codereview.chromium.org/22007003/diff/1/ash/launcher/launcher_alignme...
ash/launcher/launcher_alignment_menu.cc:17: aura::RootWindow* root)
On 2013/08/03 02:33:56, tfarina wrote:
> all these formatting changes was clang-format, not me doing manually.

clang-format does not always do the right thing. Prefer single arg per line.

https://codereview.chromium.org/22007003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/22007003/diff/1/chrome/browser/about_flags.cc...
chrome/browser/about_flags.cc:1016: "show-shelf-alignment-menu",
The internal name of the experiment should not be changed. It's not user visible
and it's stored in prefs. Changing it would make user lose the enabled
experiment.

[tfarina, 2013-08-03 06:53:15]

Thanks Xiyuan for helping reviewing this!

https://codereview.chromium.org/22007003/diff/1/ash/launcher/launcher_alignme...
File ash/launcher/launcher_alignment_menu.cc (left):

https://codereview.chromium.org/22007003/diff/1/ash/launcher/launcher_alignme...
ash/launcher/launcher_alignment_menu.cc:17: aura::RootWindow* root)
On 2013/08/03 04:44:40, xiyuan wrote:
> On 2013/08/03 02:33:56, tfarina wrote:
> > all these formatting changes was clang-format, not me doing manually.
> 
> clang-format does not always do the right thing. Prefer single arg per line.

Done.

https://codereview.chromium.org/22007003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/22007003/diff/1/chrome/browser/about_flags.cc...
chrome/browser/about_flags.cc:1016: "show-shelf-alignment-menu",
On 2013/08/03 04:44:40, xiyuan wrote:
> The internal name of the experiment should not be changed. It's not user
visible
> and it's stored in prefs. Changing it would make user lose the enabled
> experiment. 
please, see if I got this right.

[xiyuan, 2013-08-03 07:50:32]

https://codereview.chromium.org/22007003/diff/11001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/22007003/diff/11001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:1256: const char kShowLauncherAlignmentMenu[]  
  = "show-launcher-alignment-menu";
Change in PS #1 is correct (except for a nit to align the assignment op).

I should have been more clear. For about flags, the internal name is important
as it is stored in the prefs to track the enabled experiment. When chrome runs,
it gets the list of the experiment, which is a list of internal name strings and
translates it into switches. So we can change the switch name but not the
internal flag name.

[tfarina, 2013-08-03 23:01:43]

https://codereview.chromium.org/22007003/diff/11001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/22007003/diff/11001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:1256: const char kShowLauncherAlignmentMenu[]  
  = "show-launcher-alignment-menu";
On 2013/08/03 07:50:32, xiyuan wrote:
> Change in PS #1 is correct (except for a nit to align the assignment op).
> 
> I should have been more clear. For about flags, the internal name is important
> as it is stored in the prefs to track the enabled experiment. When chrome
runs,
> it gets the list of the experiment, which is a list of internal name strings
and
> translates it into switches. So we can change the switch name but not the
> internal flag name.

Xiyuan, what I can not change is "show-launcher-alignment-menu"? It should stay
that way.

But can I change kShowLauncherAlignmentMenu to kShowShelfAlignmentMenu?

[xiyuan, 2013-08-03 23:59:34]

https://codereview.chromium.org/22007003/diff/11001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/22007003/diff/11001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:1256: const char kShowLauncherAlignmentMenu[]  
  = "show-launcher-alignment-menu";
Yep. That's what I meant. 

"show-launcher-alignment-menu" as a flag's internal name should stay unchanged.
And we are free to change its underlying switch, i.e. you can change
kShowLauncherAlignmentMenu to kShowShelfAlignmentMenu.

[tfarina, 2013-08-04 02:51:35]

https://codereview.chromium.org/22007003/diff/11001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/22007003/diff/11001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:1256: const char kShowLauncherAlignmentMenu[]  
  = "show-launcher-alignment-menu";
On 2013/08/03 23:59:34, xiyuan wrote:
> Yep. That's what I meant. 
> 
> "show-launcher-alignment-menu" as a flag's internal name should stay
unchanged.
> And we are free to change its underlying switch, i.e. you can change
> kShowLauncherAlignmentMenu to kShowShelfAlignmentMenu.

Done.

[xiyuan, 2013-08-04 04:06:10]

LGTM

https://codereview.chromium.org/22007003/diff/30001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/22007003/diff/30001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:1255: // If true the alignment of the
launcher/shelf can be changed.
nit: launcher/shelf -> shelf

[tfarina, 2013-08-04 04:30:01]

https://codereview.chromium.org/22007003/diff/30001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/22007003/diff/30001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:1255: // If true the alignment of the
launcher/shelf can be changed.
On 2013/08/04 04:06:10, xiyuan wrote:
> nit: launcher/shelf -> shelf

Done.

[sky, 2013-08-05 17:04:12]

LGTM

[commit-bot: I haz the power, 2013-08-06 03:55:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/22007003/43001

[commit-bot: I haz the power, 2013-08-06 05:58:30]

Change committed as 215808