Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 22001002: Use the connectivity diagnostics launcher so that it can open as an App (Closed)

Created:
7 years, 4 months ago by Zachary Kuznia
Modified:
7 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Use the connectivity diagnostics launcher so that it can open as an App BUG=267828 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215550

Patch Set 1 #

Patch Set 2 : Fix manifest #

Total comments: 2

Patch Set 3 : Fix line length #

Patch Set 4 : Fix line length #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
A chrome/browser/resources/chromeos/connectivity_diagnostics_launcher/manifest.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Zachary Kuznia
Please take a look.
7 years, 4 months ago (2013-08-02 22:58:52 UTC) #1
Dmitry Polukhin
LGTM https://codereview.chromium.org/22001002/diff/3001/chrome/browser/resources/chromeos/connectivity_diagnostics_launcher/manifest.json File chrome/browser/resources/chromeos/connectivity_diagnostics_launcher/manifest.json (right): https://codereview.chromium.org/22001002/diff/3001/chrome/browser/resources/chromeos/connectivity_diagnostics_launcher/manifest.json#newcode9 chrome/browser/resources/chromeos/connectivity_diagnostics_launcher/manifest.json:9: "web_accessible_resources": ["index.html"] I would put all resources for ...
7 years, 4 months ago (2013-08-02 23:17:07 UTC) #2
Zachary Kuznia
mpcomplete: Could you do an OWNERS review of chrome/*/extensions/*? jhawkins: Could you do an OWNERS ...
7 years, 4 months ago (2013-08-02 23:26:33 UTC) #3
Matt Perry
lgtm
7 years, 4 months ago (2013-08-02 23:35:14 UTC) #4
James Hawkins
lgtm
7 years, 4 months ago (2013-08-03 18:44:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/22001002/9001
7 years, 4 months ago (2013-08-04 21:57:03 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-05 01:19:44 UTC) #7
Message was sent while issue was closed.
Change committed as 215550

Powered by Google App Engine
This is Rietveld 408576698