Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Side by Side Diff: chrome/browser/ui/webui/options/geolocation_options_handler.cc

Issue 21985002: Add Finch Checks to the State Machine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SMLog
Patch Set: Make Strings Const Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/google_now/manifest.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/geolocation_options_handler.h" 5 #include "chrome/browser/ui/webui/options/geolocation_options_handler.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/field_trial.h" 8 #include "base/metrics/field_trial.h"
9 #include "chrome/common/chrome_switches.h" 9 #include "chrome/common/chrome_switches.h"
10 #include "content/public/browser/web_ui.h" 10 #include "content/public/browser/web_ui.h"
11 11
12 namespace options { 12 namespace options {
13 13
14 GeolocationOptionsHandler::GeolocationOptionsHandler() {} 14 GeolocationOptionsHandler::GeolocationOptionsHandler() {}
15 15
16 GeolocationOptionsHandler::~GeolocationOptionsHandler() {} 16 GeolocationOptionsHandler::~GeolocationOptionsHandler() {}
17 17
18 void GeolocationOptionsHandler::GetLocalizedValues( 18 void GeolocationOptionsHandler::GetLocalizedValues(
19 DictionaryValue* localized_strings) { 19 DictionaryValue* localized_strings) {
20 } 20 }
21 21
22 void GeolocationOptionsHandler::InitializePage() { 22 void GeolocationOptionsHandler::InitializePage() {
23 DCHECK(web_ui()); 23 DCHECK(web_ui());
24 24
25 if ((base::FieldTrialList::FindFullName("GoogleNow") == "Enable") || 25 const char kEnablePrefix[] = "Enable";
26 const char kFieldTrialName[] = "GoogleNow";
27 std::string enable_prefix(kEnablePrefix);
28 std::string field_trial_result =
29 base::FieldTrialList::FindFullName(kFieldTrialName);
30 if ((field_trial_result.compare(
31 0,
32 enable_prefix.length(),
33 enable_prefix) == 0) ||
26 CommandLine::ForCurrentProcess()->HasSwitch( 34 CommandLine::ForCurrentProcess()->HasSwitch(
27 switches::kEnableGoogleNowIntegration)) { 35 switches::kEnableGoogleNowIntegration)) {
28 web_ui()->CallJavascriptFunction( 36 web_ui()->CallJavascriptFunction(
29 "GeolocationOptions.showGeolocationOption"); 37 "GeolocationOptions.showGeolocationOption");
30 } 38 }
31 } 39 }
32 40
33 } // namespace options 41 } // namespace options
34 42
OLDNEW
« no previous file with comments | « chrome/browser/resources/google_now/manifest.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698