build/android/dex_action.gypi - Issue 21977003: Build changes for updating Android SDK to 4.3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/dex_action.gypi

Issue 21977003: Build changes for updating Android SDK to 4.3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Turns out we need ANDROID_SDK_VERSION in constants.py (findbugs uses it). Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/dex_action.gypi

diff --git a/build/android/dex_action.gypi b/build/android/dex_action.gypi

index c41effbc0d54f3782eb8977c18a3179a644e38d3..ac956b6e3435fe99e19e63812b71475f11ed2843 100644

--- a/build/android/dex_action.gypi

+++ b/build/android/dex_action.gypi

@@ -47,7 +47,7 @@

'action': [

'python', '<(DEPTH)/build/android/gyp/dex.py',

'--dex-path=<(output_path)',

- '--android-sdk-root=<(android_sdk_root)',

+ '--android-sdk-tools=<(android_sdk_tools)',

'--configuration-name=<(CONFIGURATION_NAME)',

'--proguard-enabled=<(proguard_enabled)',

'--proguard-enabled-input-path=<(proguard_enabled_input_path)',

« no previous file with comments | « build/android/ant/apk-package-resources.xml ('k') | build/android/envsetup.sh » ('j') | no next file with comments »