Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: build/android/gyp/dex.py

Issue 21977003: Build changes for updating Android SDK to 4.3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Turns out we need ANDROID_SDK_VERSION in constants.py (findbugs uses it). Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/apk_install.py ('k') | build/android/gyp/process_resources.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 import fnmatch 7 import fnmatch
8 import optparse 8 import optparse
9 import os 9 import os
10 import sys 10 import sys
11 11
12 from util import build_utils 12 from util import build_utils
13 from util import md5_check 13 from util import md5_check
14 14
15 15
16 def DoDex(options, paths): 16 def DoDex(options, paths):
17 dx_binary = os.path.join(options.android_sdk_root, 'platform-tools', 'dx') 17 dx_binary = os.path.join(options.android_sdk_tools, 'dx')
18 dex_cmd = [dx_binary, '--dex', '--output', options.dex_path] + paths 18 dex_cmd = [dx_binary, '--dex', '--output', options.dex_path] + paths
19 19
20 record_path = '%s.md5.stamp' % options.dex_path 20 record_path = '%s.md5.stamp' % options.dex_path
21 md5_check.CallAndRecordIfStale( 21 md5_check.CallAndRecordIfStale(
22 lambda: build_utils.CheckCallDie(dex_cmd, suppress_output=True), 22 lambda: build_utils.CheckCallDie(dex_cmd, suppress_output=True),
23 record_path=record_path, 23 record_path=record_path,
24 input_paths=paths, 24 input_paths=paths,
25 input_strings=dex_cmd) 25 input_strings=dex_cmd)
26 26
27 build_utils.Touch(options.dex_path) 27 build_utils.Touch(options.dex_path)
28 28
29 29
30 def main(argv): 30 def main(argv):
31 parser = optparse.OptionParser() 31 parser = optparse.OptionParser()
32 parser.add_option('--android-sdk-root', help='Android sdk root directory.') 32 parser.add_option('--android-sdk-tools',
33 help='Android sdk build tools directory.')
33 parser.add_option('--dex-path', help='Dex output path.') 34 parser.add_option('--dex-path', help='Dex output path.')
34 parser.add_option('--configuration-name', 35 parser.add_option('--configuration-name',
35 help='The build CONFIGURATION_NAME.') 36 help='The build CONFIGURATION_NAME.')
36 parser.add_option('--proguard-enabled', 37 parser.add_option('--proguard-enabled',
37 help='"true" if proguard is enabled.') 38 help='"true" if proguard is enabled.')
38 parser.add_option('--proguard-enabled-input-path', 39 parser.add_option('--proguard-enabled-input-path',
39 help='Path to dex in Release mode when proguard is enabled.') 40 help='Path to dex in Release mode when proguard is enabled.')
40 parser.add_option('--stamp', help='Path to touch on success.') 41 parser.add_option('--stamp', help='Path to touch on success.')
41 42
42 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja. 43 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
43 parser.add_option('--ignore', help='Ignored.') 44 parser.add_option('--ignore', help='Ignored.')
44 45
45 options, paths = parser.parse_args() 46 options, paths = parser.parse_args()
46 47
47 if (options.proguard_enabled == "true" 48 if (options.proguard_enabled == "true"
48 and options.configuration_name == "Release"): 49 and options.configuration_name == "Release"):
49 paths = [options.proguard_enabled_input_path] 50 paths = [options.proguard_enabled_input_path]
50 51
51 DoDex(options, paths) 52 DoDex(options, paths)
52 53
53 if options.stamp: 54 if options.stamp:
54 build_utils.Touch(options.stamp) 55 build_utils.Touch(options.stamp)
55 56
56 57
57 if __name__ == '__main__': 58 if __name__ == '__main__':
58 sys.exit(main(sys.argv)) 59 sys.exit(main(sys.argv))
59 60
OLDNEW
« no previous file with comments | « build/android/gyp/apk_install.py ('k') | build/android/gyp/process_resources.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698