Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 2197653005: Increase test runtime timeout configuration for hot_reload tests in debug mode as we are about to a… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 8c10e10ea21291d52b3211240bdd578735eaac1e..3014371e8b9bb94baf788d7d66d16c2b3ca86698 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -70,7 +70,7 @@ class RuntimeConfiguration {
RuntimeConfiguration._subclass();
int computeTimeoutMultiplier(
- {String mode, bool isChecked: false, String arch}) {
+ {String mode, bool isChecked: false, bool isReload: false, String arch}) {
return 1;
}
@@ -164,7 +164,7 @@ class DartVmRuntimeConfiguration extends RuntimeConfiguration {
DartVmRuntimeConfiguration() : super._subclass();
int computeTimeoutMultiplier(
- {String mode, bool isChecked: false, String arch}) {
+ {String mode, bool isChecked: false, bool isReload: false, String arch}) {
int multiplier = 1;
switch (arch) {
case 'simarm':
@@ -183,6 +183,9 @@ class DartVmRuntimeConfiguration extends RuntimeConfiguration {
}
if (mode == 'debug') {
multiplier *= 2;
+ if (isReload) {
+ multiplier *= 2;
+ }
}
return multiplier;
}
@@ -192,13 +195,14 @@ class DartVmRuntimeConfiguration extends RuntimeConfiguration {
/// program named Dump Render Tree, hence the name.
class DrtRuntimeConfiguration extends DartVmRuntimeConfiguration {
int computeTimeoutMultiplier(
- {String mode, bool isChecked: false, String arch}) {
+ {String mode, bool isChecked: false, bool isReload: false, String arch}) {
return 4 // Allow additional time for browser testing to run.
// TODO(ahe): We might need to distinquish between DRT for running
// JavaScript and Dart code. I'm not convinced the inherited timeout
// multiplier is relevant for JavaScript.
*
- super.computeTimeoutMultiplier(mode: mode, isChecked: isChecked);
+ super.computeTimeoutMultiplier(
+ mode: mode, isChecked: isChecked, isRelease: isReload);
}
}
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698