Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: tools/testing/dart/test_options.dart

Issue 2197653005: Increase test runtime timeout configuration for hot_reload tests in debug mode as we are about to a… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_options_parser; 5 library test_options_parser;
6 6
7 import "dart:io"; 7 import "dart:io";
8 import "drt_updater.dart"; 8 import "drt_updater.dart";
9 import "test_suite.dart"; 9 import "test_suite.dart";
10 import "path.dart"; 10 import "path.dart";
(...skipping 807 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 } 818 }
819 819
820 // Adjust default timeout based on mode, compiler, and sometimes runtime. 820 // Adjust default timeout based on mode, compiler, and sometimes runtime.
821 if (configuration['timeout'] == -1) { 821 if (configuration['timeout'] == -1) {
822 int compilerMulitiplier = 822 int compilerMulitiplier =
823 new CompilerConfiguration(configuration).computeTimeoutMultiplier(); 823 new CompilerConfiguration(configuration).computeTimeoutMultiplier();
824 int runtimeMultiplier = new RuntimeConfiguration(configuration) 824 int runtimeMultiplier = new RuntimeConfiguration(configuration)
825 .computeTimeoutMultiplier( 825 .computeTimeoutMultiplier(
826 mode: configuration['mode'], 826 mode: configuration['mode'],
827 isChecked: configuration['checked'], 827 isChecked: configuration['checked'],
828 isReload: configuration['hot_reload'],
rmacnak 2016/08/01 17:51:03 With John's change, || configuration['hot_reload_
siva 2016/08/01 21:33:18 Done.
828 arch: configuration['arch']); 829 arch: configuration['arch']);
829 configuration['timeout'] = 60 * compilerMulitiplier * runtimeMultiplier; 830 configuration['timeout'] = 60 * compilerMulitiplier * runtimeMultiplier;
830 } 831 }
831 832
832 return [configuration]; 833 return [configuration];
833 } 834 }
834 835
835 /** 836 /**
836 * Helper for _expandConfigurations. Creates a new configuration and adds it 837 * Helper for _expandConfigurations. Creates a new configuration and adds it
837 * to a list, for use in a case when a particular configuration has multiple 838 * to a list, for use in a case when a particular configuration has multiple
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
904 if (option.keys.contains(name)) { 905 if (option.keys.contains(name)) {
905 return option; 906 return option;
906 } 907 }
907 } 908 }
908 print('Unknown test option $name'); 909 print('Unknown test option $name');
909 exit(1); 910 exit(1);
910 } 911 }
911 912
912 List<_TestOptionSpecification> _options; 913 List<_TestOptionSpecification> _options;
913 } 914 }
OLDNEW
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698