Issue 21968004: Updated usrsctp to fix various issues for windows (using changes pushed upstream) and unified SHA1 …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21968004: Updated usrsctp to fix various issues for windows (using changes pushed upstream) and unified SHA1 … (Closed)

Created:
7 years, 4 months ago by ldixon

Modified:
7 years, 4 months ago

Reviewers:
Mallinath (Gone from Chromium), jiayl, mallinath, juberti

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Updated usrsctp to fix various issues for windows (using changes pushed upstream) and unified SHA1 treatment with libjingle. Note: HAVE_SCTP is still currently turned off for windows (while investigating an apparent issue in win xp) (patch from issue 19522005; exactly the same, except HAVE_SCTP is not turned on for windows) BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215983

Patch Set 1 #

Patch Set 2 : fixed indent #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+217 lines, -107 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/usrsctp/README.chromium	View	2 chunks	+13 lines, -7 lines	0 comments	Download
M	third_party/usrsctp/localchanges.patch	View	9 chunks	+148 lines, -49 lines	0 comments	Download
M	third_party/usrsctp/overrides/usrsctplib/netinet/sctp_nss_sha1.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/usrsctp/overrides/usrsctplib/netinet/sctp_nss_sha1.c	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	third_party/usrsctp/overrides/usrsctplib/netinet/sctp_os_userspace.h	View	5 chunks	+11 lines, -13 lines	0 comments	Download
M	third_party/usrsctp/overrides/usrsctplib/netinet/sctp_sha1.h	View	2 chunks	+24 lines, -5 lines	0 comments	Download
M	third_party/usrsctp/usrsctp.gyp	View	7 chunks	+14 lines, -29 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ldixon@google.com/21968004/7001

7 years, 4 months ago (2013-08-06 18:31:28 UTC) #4

Message was sent while issue was closed.

Change committed as 215983

Expand Messages | Collapse Messages