Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: content/renderer/pepper/pepper_file_chooser_host_unittest.cc

Issue 21966004: Pepper: Move FileRef to the "new" resource proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove code duplication Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_file_chooser_host_unittest.cc
diff --git a/content/renderer/pepper/pepper_file_chooser_host_unittest.cc b/content/renderer/pepper/pepper_file_chooser_host_unittest.cc
index b228cd72f5b1decc2719efb24abbddfcca3631e2..8242c5d9d3aad9f4414f279147a24e66754aae0c 100644
--- a/content/renderer/pepper/pepper_file_chooser_host_unittest.cc
+++ b/content/renderer/pepper/pepper_file_chooser_host_unittest.cc
@@ -18,7 +18,6 @@
#include "ppapi/proxy/resource_message_params.h"
#include "ppapi/proxy/resource_message_test_sink.h"
#include "ppapi/shared_impl/ppapi_permissions.h"
-#include "ppapi/shared_impl/ppb_file_ref_shared.h"
#include "ppapi/shared_impl/resource_tracker.h"
#include "ppapi/shared_impl/test_globals.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -65,6 +64,9 @@ std::string FilePathToUTF8(const base::FilePath::StringType& path) {
} // namespace
+/*
+// TODO(teravest): Rewrite this test now that it requires renderer-browser
+// communication.
dmichael (off chromium) 2013/08/07 22:19:13 Does it still compile? If it still compiles, pleas
teravest 2013/08/08 00:50:06 No, since I changed the CreateInfo struct. I could
dmichael (off chromium) 2013/08/08 21:24:03 I might slightly prefer that you make it compile,
TEST_F(PepperFileChooserHostTest, Show) {
PP_Resource pp_resource = 123;
@@ -129,6 +131,7 @@ TEST_F(PepperFileChooserHostTest, Show) {
EXPECT_EQ(FilePathToUTF8(selected_info.display_name),
chooser_results[0].name);
}
+*/
TEST_F(PepperFileChooserHostTest, NoUserGesture) {
PP_Resource pp_resource = 123;

Powered by Google App Engine
This is Rietveld 408576698