content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc - Issue 21966004: Pepper: Move FileRef to the "new" resource proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc

Issue 21966004: Pepper: Move FileRef to the "new" resource proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove code duplication Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc ('K') | « chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc ('k') | content/browser/renderer_host/pepper/pepper_renderer_connection.h » ('j') | content/renderer/pepper/pepper_file_chooser_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc

diff --git a/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc b/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc

index 27ba37dfcca0ddbda4168912d1448b634d1d7dac..2bd44c129c0f20bb5cfb674a858ceb9bc3c24a6c 100644

--- a/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc

+++ b/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc

@@ -90,7 +90,10 @@ int32_t PepperExternalFileRefBackend::GetAbsolutePath(

ppapi::host::ReplyMessageContext reply_context) {

host_->SendReply(reply_context,

PpapiPluginMsg_FileRef_GetAbsolutePathReply(path_.AsUTF8Unsafe()));

- return PP_OK;

+ // Use PP_OK_COMPLETIONPENDING instead of PP_OK since we've already sent our

+ // reply above.

+ return PP_OK_COMPLETIONPENDING;

}

fileapi::FileSystemURL PepperExternalFileRefBackend::GetFileSystemURL() const {