Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Side by Side Diff: content/renderer/pepper/pepper_file_chooser_host_unittest.cc

Issue 21966004: Pepper: Move FileRef to the "new" resource proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bug in GetAbsolutePath (fixes FlashDRM test failure) Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_path.h" 5 #include "base/files/file_path.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "content/common/view_messages.h" 7 #include "content/common/view_messages.h"
8 #include "content/public/common/file_chooser_params.h" 8 #include "content/public/common/file_chooser_params.h"
9 #include "content/public/test/render_view_test.h" 9 #include "content/public/test/render_view_test.h"
10 #include "content/renderer/pepper/mock_renderer_ppapi_host.h" 10 #include "content/renderer/pepper/mock_renderer_ppapi_host.h"
11 #include "content/renderer/pepper/pepper_file_chooser_host.h" 11 #include "content/renderer/pepper/pepper_file_chooser_host.h"
12 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
13 #include "content/renderer/pepper/unittest_instance_util.h"
12 #include "content/renderer/render_view_impl.h" 14 #include "content/renderer/render_view_impl.h"
13 #include "content/test/test_content_client.h" 15 #include "content/test/test_content_client.h"
14 #include "ppapi/c/pp_errors.h" 16 #include "ppapi/c/pp_errors.h"
15 #include "ppapi/host/host_message_context.h" 17 #include "ppapi/host/host_message_context.h"
16 #include "ppapi/host/ppapi_host.h" 18 #include "ppapi/host/ppapi_host.h"
17 #include "ppapi/proxy/ppapi_messages.h" 19 #include "ppapi/proxy/ppapi_messages.h"
18 #include "ppapi/proxy/resource_message_params.h" 20 #include "ppapi/proxy/resource_message_params.h"
19 #include "ppapi/proxy/resource_message_test_sink.h" 21 #include "ppapi/proxy/resource_message_test_sink.h"
22 #include "ppapi/shared_impl/file_ref_create_info.h"
20 #include "ppapi/shared_impl/ppapi_permissions.h" 23 #include "ppapi/shared_impl/ppapi_permissions.h"
21 #include "ppapi/shared_impl/ppb_file_ref_shared.h"
22 #include "ppapi/shared_impl/resource_tracker.h" 24 #include "ppapi/shared_impl/resource_tracker.h"
23 #include "ppapi/shared_impl/test_globals.h"
24 #include "testing/gtest/include/gtest/gtest.h" 25 #include "testing/gtest/include/gtest/gtest.h"
25 #include "ui/shell_dialogs/selected_file_info.h" 26 #include "ui/shell_dialogs/selected_file_info.h"
26 27
27 namespace content { 28 namespace content {
28 29
29 namespace { 30 namespace {
30 31
31 class PepperFileChooserHostTest : public RenderViewTest { 32 class PepperFileChooserHostTest : public RenderViewTest {
32 public: 33 public:
33 PepperFileChooserHostTest() 34 PepperFileChooserHostTest()
34 : pp_instance_(123456) {} 35 : pp_instance_(123456) {}
35 36
36 virtual void SetUp() { 37 virtual void SetUp() {
37 SetContentClient(&client_); 38 SetContentClient(&client_);
38 RenderViewTest::SetUp(); 39 RenderViewTest::SetUp();
40 ASSERT_TRUE(instance_util_.SetUp());
41 pp_instance_ = instance_util_.instance()->pp_instance();
42 }
39 43
40 globals_.GetResourceTracker()->DidCreateInstance(pp_instance_);
41 }
42 virtual void TearDown() { 44 virtual void TearDown() {
43 globals_.GetResourceTracker()->DidDeleteInstance(pp_instance_);
44
45 RenderViewTest::TearDown(); 45 RenderViewTest::TearDown();
46 instance_util_.TearDown();
46 } 47 }
47 48
48 PP_Instance pp_instance() const { return pp_instance_; } 49 PP_Instance pp_instance() const { return pp_instance_; }
49 50
50 private: 51 private:
52 UnittestInstanceUtil instance_util_;
51 PP_Instance pp_instance_; 53 PP_Instance pp_instance_;
52
53 ppapi::TestGlobals globals_;
54 TestContentClient client_; 54 TestContentClient client_;
55 }; 55 };
56 56
57 // For testing to convert our hardcoded file paths to 8-bit. 57 // For testing to convert our hardcoded file paths to 8-bit.
58 std::string FilePathToUTF8(const base::FilePath::StringType& path) { 58 std::string FilePathToUTF8(const base::FilePath::StringType& path) {
59 #if defined(OS_WIN) 59 #if defined(OS_WIN)
60 return UTF16ToUTF8(path); 60 return UTF16ToUTF8(path);
61 #else 61 #else
62 return path; 62 return path;
63 #endif 63 #endif
64 } 64 }
65 65
66 } // namespace 66 } // namespace
67 67
68 /*
68 TEST_F(PepperFileChooserHostTest, Show) { 69 TEST_F(PepperFileChooserHostTest, Show) {
69 PP_Resource pp_resource = 123; 70 PP_Resource pp_resource = 123;
70 71
71 MockRendererPpapiHost host(view_, pp_instance()); 72 MockRendererPpapiHost host(view_, pp_instance());
72 PepperFileChooserHost chooser(&host, pp_instance(), pp_resource); 73 PepperFileChooserHost chooser(&host, pp_instance(), pp_resource);
73 74
74 // Say there's a user gesture. 75 // Say there's a user gesture.
75 host.set_has_user_gesture(true); 76 host.set_has_user_gesture(true);
76 77
77 std::vector<std::string> accept; 78 std::vector<std::string> accept;
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 IPC::Message reply_msg; 115 IPC::Message reply_msg;
115 ASSERT_TRUE(host.sink().GetFirstResourceReplyMatching( 116 ASSERT_TRUE(host.sink().GetFirstResourceReplyMatching(
116 PpapiPluginMsg_FileChooser_ShowReply::ID, &reply_params, &reply_msg)); 117 PpapiPluginMsg_FileChooser_ShowReply::ID, &reply_params, &reply_msg));
117 118
118 // Basic validation of reply. 119 // Basic validation of reply.
119 EXPECT_EQ(call_params.sequence(), reply_params.sequence()); 120 EXPECT_EQ(call_params.sequence(), reply_params.sequence());
120 EXPECT_EQ(PP_OK, reply_params.result()); 121 EXPECT_EQ(PP_OK, reply_params.result());
121 PpapiPluginMsg_FileChooser_ShowReply::Schema::Param reply_msg_param; 122 PpapiPluginMsg_FileChooser_ShowReply::Schema::Param reply_msg_param;
122 ASSERT_TRUE(PpapiPluginMsg_FileChooser_ShowReply::Read(&reply_msg, 123 ASSERT_TRUE(PpapiPluginMsg_FileChooser_ShowReply::Read(&reply_msg,
123 &reply_msg_param)); 124 &reply_msg_param));
124 const std::vector<ppapi::PPB_FileRef_CreateInfo>& chooser_results = 125 const std::vector<ppapi::FileRef_CreateInfo>& chooser_results =
125 reply_msg_param.a; 126 reply_msg_param.a;
126 ASSERT_EQ(1u, chooser_results.size()); 127 ASSERT_EQ(1u, chooser_results.size());
127 // Note path is empty because this is an external filesystem. 128 // Note path is empty because this is an external filesystem.
128 EXPECT_EQ(std::string(), chooser_results[0].path); 129 EXPECT_EQ(std::string(), chooser_results[0].internal_path);
129 EXPECT_EQ(FilePathToUTF8(selected_info.display_name), 130 EXPECT_EQ(FilePathToUTF8(selected_info.display_name),
130 chooser_results[0].name); 131 chooser_results[0].display_name);
131 } 132 }
133 */
132 134
133 TEST_F(PepperFileChooserHostTest, NoUserGesture) { 135 TEST_F(PepperFileChooserHostTest, NoUserGesture) {
134 PP_Resource pp_resource = 123; 136 PP_Resource pp_resource = 123;
135 137
136 MockRendererPpapiHost host(view_, pp_instance()); 138 MockRendererPpapiHost host(view_, pp_instance());
137 PepperFileChooserHost chooser(&host, pp_instance(), pp_resource); 139 PepperFileChooserHost chooser(&host, pp_instance(), pp_resource);
138 140
139 // Say there's no user gesture. 141 // Say there's no user gesture.
140 host.set_has_user_gesture(false); 142 host.set_has_user_gesture(false);
141 143
142 std::vector<std::string> accept; 144 std::vector<std::string> accept;
143 accept.push_back("text/plain"); 145 accept.push_back("text/plain");
144 PpapiHostMsg_FileChooser_Show show_msg(false, false, std::string(), accept); 146 PpapiHostMsg_FileChooser_Show show_msg(false, false, std::string(), accept);
145 147
146 ppapi::proxy::ResourceMessageCallParams call_params(pp_resource, 0); 148 ppapi::proxy::ResourceMessageCallParams call_params(pp_resource, 0);
147 ppapi::host::HostMessageContext context(call_params); 149 ppapi::host::HostMessageContext context(call_params);
148 int32 result = chooser.OnResourceMessageReceived(show_msg, &context); 150 int32 result = chooser.OnResourceMessageReceived(show_msg, &context);
149 EXPECT_EQ(PP_ERROR_NO_USER_GESTURE, result); 151 EXPECT_EQ(PP_ERROR_NO_USER_GESTURE, result);
150 } 152 }
151 153
152 } // namespace content 154 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698