Pepper: Move FileRef to the "new" resource proxy.

ppapi/shared_impl/file_ref_create_info.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ppapi/shared_impl/file_ref_create_info.h"
+
+#include "base/files/file_path.h"

[yzshen1, 2013/08/08 23:16:21]

It is already included in .h.

[teravest, 2013/08/09 02:00:08]

Done.

+#include "base/logging.h"
+#include "base/strings/utf_string_conversions.h"
+#include "ppapi/c/pp_file_info.h"
+
+namespace ppapi {
+
+namespace {
+
+std::string GetNameForExternalFilePath(const base::FilePath& in_path) {
+  const base::FilePath::StringType& path = in_path.value();
+  size_t pos = path.rfind(base::FilePath::kSeparators[0]);
+  CHECK(pos != base::FilePath::StringType::npos);
+#if defined(OS_WIN)
+  return base::WideToUTF8(path.substr(pos + 1));
+#elif defined(OS_POSIX)
+  return path.substr(pos + 1);
+#else
+#error "Unsupported platform."
+#endif
+}
+
+}  // namespace
+
+bool FileRefCreateInfo::IsValid() const {
+  return file_system_type != PP_FILESYSTEMTYPE_INVALID;
+}
+
+FileRefCreateInfo
+MakeExternalFileRefCreateInfo(const base::FilePath& external_path,
+                              const std::string& display_name,
+                              int pending_host_resource_id) {
+  FileRefCreateInfo info;
+  info.file_system_type = PP_FILESYSTEMTYPE_EXTERNAL;
+  if (display_name != "")

[dmichael (off chromium), 2013/08/08 21:24:03]

!display_name.empty()?

[yzshen1, 2013/08/08 23:16:21]

please use empty().

[teravest, 2013/08/09 02:00:08]

Done.

+    info.display_name = display_name;
+  else
+    info.display_name = GetNameForExternalFilePath(external_path);
+  info.pending_host_resource_id = pending_host_resource_id;
+  return info;
+}
+
+}  // namespace ppapi