Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: content/renderer/resource_fetcher_browsertest.cc

Issue 21955003: Cleanup: Use content::kAboutBlankURL instead of the raw string in contents/. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix build Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/cpp_bound_class_unittest.cc ('k') | content/shell/renderer/webkit_test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/resource_fetcher_browsertest.cc
===================================================================
--- content/renderer/resource_fetcher_browsertest.cc (revision 215674)
+++ content/renderer/resource_fetcher_browsertest.cc (working copy)
@@ -10,6 +10,7 @@
#include "base/message_loop/message_loop.h"
#include "base/timer/timer.h"
#include "content/public/common/content_switches.h"
+#include "content/public/common/url_constants.h"
#include "content/public/renderer/render_view.h"
#include "content/public/test/test_utils.h"
#include "content/shell/shell.h"
@@ -217,7 +218,7 @@
// If this flakes, use http://crbug.com/51622.
IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcherDownload) {
// Need to spin up the renderer.
- NavigateToURL(shell(), GURL("about:blank"));
+ NavigateToURL(shell(), GURL(kAboutBlankURL));
ASSERT_TRUE(test_server()->Start());
GURL url(test_server()->GetURL("files/simple_page.html"));
@@ -229,7 +230,7 @@
IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcher404) {
// Need to spin up the renderer.
- NavigateToURL(shell(), GURL("about:blank"));
+ NavigateToURL(shell(), GURL(kAboutBlankURL));
// Test 404 response.
ASSERT_TRUE(test_server()->Start());
@@ -243,7 +244,7 @@
// If this flakes, use http://crbug.com/51622.
IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcherDidFail) {
// Need to spin up the renderer.
- NavigateToURL(shell(), GURL("about:blank"));
+ NavigateToURL(shell(), GURL(kAboutBlankURL));
PostTaskToInProcessRendererAndWait(
base::Bind(&ResourceFetcherTests::ResourceFetcherDidFailOnRenderer,
@@ -252,7 +253,7 @@
IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcherTimeout) {
// Need to spin up the renderer.
- NavigateToURL(shell(), GURL("about:blank"));
+ NavigateToURL(shell(), GURL(kAboutBlankURL));
// Grab a page that takes at least 1 sec to respond, but set the fetcher to
// timeout in 0 sec.
@@ -266,7 +267,7 @@
IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcherDeletedInCallback) {
// Need to spin up the renderer.
- NavigateToURL(shell(), GURL("about:blank"));
+ NavigateToURL(shell(), GURL(kAboutBlankURL));
// Grab a page that takes at least 1 sec to respond, but set the fetcher to
// timeout in 0 sec.
« no previous file with comments | « content/renderer/cpp_bound_class_unittest.cc ('k') | content/shell/renderer/webkit_test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698