Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 21955003: Cleanup: Use content::kAboutBlankURL instead of the raw string in contents/. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix build Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
===================================================================
--- content/browser/web_contents/web_contents_impl_unittest.cc (revision 215674)
+++ content/browser/web_contents/web_contents_impl_unittest.cc (working copy)
@@ -17,7 +17,6 @@
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_source.h"
-#include "content/public/browser/notification_source.h"
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_ui_controller.h"
@@ -42,10 +41,9 @@
public:
virtual WebUIController* CreateWebUIControllerForURL(
WebUI* web_ui, const GURL& url) const OVERRIDE {
- if (!UseWebUI(url))
- return NULL;
-
- return new WebUIController(web_ui);
+ if (!UseWebUI(url))
+ return NULL;
+ return new WebUIController(web_ui);
}
virtual WebUI::TypeID GetWebUIType(BrowserContext* browser_context,
@@ -73,7 +71,7 @@
class TestInterstitialPageDelegate : public InterstitialPageDelegate {
public:
- TestInterstitialPageDelegate(TestInterstitialPage* interstitial_page)
+ explicit TestInterstitialPageDelegate(TestInterstitialPage* interstitial_page)
: interstitial_page_(interstitial_page) {}
virtual void CommandReceived(const std::string& command) OVERRIDE;
virtual std::string GetHTMLContents() OVERRIDE { return std::string(); }
@@ -271,7 +269,7 @@
class TestWebContentsObserver : public WebContentsObserver {
public:
- TestWebContentsObserver(WebContents* contents)
+ explicit TestWebContentsObserver(WebContents* contents)
: WebContentsObserver(contents) {
}
virtual ~TestWebContentsObserver() {}
@@ -2110,7 +2108,7 @@
// A navigation to about:whatever should always look like a navigation to
// about:blank
- GURL url_normalized("about:blank");
+ GURL url_normalized(kAboutBlankURL);
GURL url_from_ipc("about:whatever");
// We navigate the test WebContents to about:blank, since NavigateAndCommit
« no previous file with comments | « content/browser/web_contents/navigation_controller_impl_unittest.cc ('k') | content/renderer/cpp_bound_class_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698