content/browser/session_history_browsertest.cc - Issue 21955003: Cleanup: Use content::kAboutBlankURL instead of the raw string in contents/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/session_history_browsertest.cc

Issue 21955003: Cleanup: Use content::kAboutBlankURL instead of the raw string in contents/. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix build Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_browsertest.cc ('k') | content/browser/web_contents/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/session_history_browsertest.cc

===================================================================

--- content/browser/session_history_browsertest.cc (revision 215674)

+++ content/browser/session_history_browsertest.cc (working copy)

@@ -164,10 +164,10 @@

EXPECT_EQ("bot1", GetTabTitle());

GoBack();

- EXPECT_EQ("about:blank", GetTabTitle());

+ EXPECT_EQ(std::string(kAboutBlankURL), GetTabTitle());

ASSERT_FALSE(CanGoBack());

- EXPECT_EQ("about:blank", GetTabTitle());

+ EXPECT_EQ(std::string(kAboutBlankURL), GetTabTitle());

GoForward();

EXPECT_EQ("bot1", GetTabTitle());

@@ -203,7 +203,7 @@

EXPECT_EQ(frames, GetTabURL());

GoBack();

- EXPECT_EQ("about:blank", GetTabTitle());

+ EXPECT_EQ(std::string(kAboutBlankURL), GetTabTitle());

EXPECT_EQ(GURL(kAboutBlankURL), GetTabURL());

GoForward();

@@ -400,10 +400,10 @@

// history is [blank, bot1, bot2, *bot3]

JavascriptGo("-3");

- EXPECT_EQ("about:blank", GetTabTitle());

+ EXPECT_EQ(std::string(kAboutBlankURL), GetTabTitle());

ASSERT_FALSE(CanGoBack());

- EXPECT_EQ("about:blank", GetTabTitle());

+ EXPECT_EQ(std::string(kAboutBlankURL), GetTabTitle());

JavascriptGo("1");

EXPECT_EQ("bot1", GetTabTitle());

@@ -419,10 +419,10 @@

EXPECT_EQ("bot1", GetTabTitle());

JavascriptGo("-1");

- EXPECT_EQ("about:blank", GetTabTitle());

+ EXPECT_EQ(std::string(kAboutBlankURL), GetTabTitle());

ASSERT_FALSE(CanGoBack());

- EXPECT_EQ("about:blank", GetTabTitle());

+ EXPECT_EQ(std::string(kAboutBlankURL), GetTabTitle());

JavascriptGo("1");

EXPECT_EQ("bot1", GetTabTitle());