content/browser/media/media_browsertest.cc - Issue 21955003: Cleanup: Use content::kAboutBlankURL instead of the raw string in contents/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/media_browsertest.cc

Issue 21955003: Cleanup: Use content::kAboutBlankURL instead of the raw string in contents/. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix build Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/resource_dispatcher_host_browsertest.cc ('k') | content/browser/renderer_host/render_view_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/media_browsertest.cc

===================================================================

--- content/browser/media/media_browsertest.cc (revision 215674)

+++ content/browser/media/media_browsertest.cc (working copy)

@@ -7,6 +7,7 @@

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/common/url_constants.h"

#include "content/public/test/browser_test_utils.h"

#include "content/shell/shell.h"

#include "content/test/content_browser_test_utils.h"

@@ -34,7 +35,7 @@

std::vector<StringPair>::const_iterator itr = query_params->begin();

query = base::StringPrintf("%s=%s", itr->first, itr->second);

++itr;

- for (;itr != query_params->end(); ++itr) {

+ for (; itr != query_params->end(); ++itr) {

query.append(base::StringPrintf("&%s=%s", itr->first, itr->second));

}

@@ -184,7 +185,7 @@

// Covers tear-down when navigating away as opposed to browser exiting.

IN_PROC_BROWSER_TEST_F(MediaTest, Navigate) {

PlayVideo("bear.ogv", false);

- NavigateToURL(shell(), GURL("about:blank"));

+ NavigateToURL(shell(), GURL(kAboutBlankURL));

EXPECT_FALSE(shell()->web_contents()->IsCrashed());

}