Issue 21952005: Reland: Remove webkit_chromium_resources.pak entries.

Issue 21952005: Reland: Remove webkit_chromium_resources.pak entries. (Closed)

Created:
7 years, 4 months ago by pkotwicz

Modified:
7 years, 4 months ago

Reviewers:
tfarina

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland: Remove webkit_chromium_resources.pak entries. webkit_chromium_resources.pak was kept along side with blink_resources.pak, while DumpRenderTree was being updated on the Blink side, since that already happened and Blink has rolled into Chromium, we should be able to remove this now. TBR=tfarina@chromium.org BUG=265748 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215397

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -26 lines)			Patch
M	android_webview/android_webview.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_dll.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_repack_chrome.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	4 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	chrome/test/gpu/test_support_gpu.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/gpu/test_support_gpu.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/content_shell.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/gritsettings/resource_ids	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	webkit/child/webkitplatformsupport_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/common/cursors/webcursor_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/support/platform_support_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/webkit_resources.gyp	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/21952005/1

7 years, 4 months ago (2013-08-02 21:33:18 UTC) #1

tfarina

Thanks Peter! lgtm https://chromiumcodereview.appspot.com/21952005/diff/1/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (left): https://chromiumcodereview.appspot.com/21952005/diff/1/chrome/chrome_tests_unit.gypi#oldcode2367 chrome/chrome_tests_unit.gypi:2367: '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc', this should have been added ...

7 years, 4 months ago (2013-08-02 22:15:28 UTC) #2

tfarina

7 years, 4 months ago (2013-08-02 23:11:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r215397 (presubmit successful).

Expand Messages | Collapse Messages