Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 21952002: Move pdf files into pdf.gypi (Closed)

Created:
7 years, 4 months ago by robertphillips
Modified:
7 years, 4 months ago
Reviewers:
edisonn, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

In preparation for make Chromium's skia.gyp use pdf.gypi. Committed: http://code.google.com/p/skia/source/detail?r=10526

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed code review issue #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -33 lines) Patch
M gyp/pdf.gyp View 1 1 chunk +4 lines, -33 lines 0 comments Download
A gyp/pdf.gypi View 1 chunk +50 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
robertphillips
7 years, 4 months ago (2013-08-02 18:37:26 UTC) #1
djsollen
lgtm with one nit https://codereview.chromium.org/21952002/diff/1/gyp/pdf.gyp File gyp/pdf.gyp (right): https://codereview.chromium.org/21952002/diff/1/gyp/pdf.gyp#newcode21 gyp/pdf.gyp:21: 'pdf.gypi', comment here... # Makes ...
7 years, 4 months ago (2013-08-02 18:47:19 UTC) #2
robertphillips
https://codereview.chromium.org/21952002/diff/1/gyp/pdf.gyp File gyp/pdf.gyp (right): https://codereview.chromium.org/21952002/diff/1/gyp/pdf.gyp#newcode21 gyp/pdf.gyp:21: 'pdf.gypi', On 2013/08/02 18:47:19, djsollen wrote: > comment here... ...
7 years, 4 months ago (2013-08-02 18:50:59 UTC) #3
edisonn
https://codereview.chromium.org/21952002/diff/5001/gyp/pdf.gypi File gyp/pdf.gypi (right): https://codereview.chromium.org/21952002/diff/5001/gyp/pdf.gypi#newcode47 gyp/pdf.gypi:47: # tab-width:2 seems tab width is 4, maybe we ...
7 years, 4 months ago (2013-08-02 19:23:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/21952002/5001
7 years, 4 months ago (2013-08-04 15:01:31 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-04 15:09:24 UTC) #6
Message was sent while issue was closed.
Change committed as 10526

Powered by Google App Engine
This is Rietveld 408576698