Remove operator== from SkPaint

Remove operator== from SkPaint

Committed: http://code.google.com/p/skia/source/detail?r=10603

[mtklein, 2013-08-05 18:18:14]

looks good in spirit.  just one nit on the implementation.

https://codereview.chromium.org/21949007/diff/1/tests/PaintTest.cpp
File tests/PaintTest.cpp (right):

https://codereview.chromium.org/21949007/diff/1/tests/PaintTest.cpp#newcode139
tests/PaintTest.cpp:139: static bool PaintEquals(const SkPaint& a, const SkPaint
&b) {
I think we can ditch the class and just have a free function?

e.g. SkPaintShallowEqual(const SkPaint& a, const SkPaint& b) ?

[mtklein, 2013-08-05 18:18:15]

looks good in spirit.  just one nit on the implementation.

[sglez, 2013-08-05 18:58:27]

Changed from friend class to friend function.

[mtklein, 2013-08-05 19:34:38]

On 2013/08/05 18:58:27, sglez wrote:
> Changed from friend class to friend function.

lgtm

[reed1, 2013-08-05 20:40:36]

change is good, except I think we can simplify the unittest to not require
special knowledge.

https://codereview.chromium.org/21949007/diff/17001/tests/PaintTest.cpp
File tests/PaintTest.cpp (right):

https://codereview.chromium.org/21949007/diff/17001/tests/PaintTest.cpp#newco...
tests/PaintTest.cpp:136: bool SkPaintShallowEquals(const SkPaint& a, const
SkPaint &b) {
I think this guy should just test for the fields it cares about, using public
getters, just for this test. Then it need not be a friend of SkPaint.

[sglez, 2013-08-05 23:38:00]

Small static function that only does what the test needs.

[reed1, 2013-08-06 17:37:22]

if the tests still pass, lgtm

[mtklein, 2013-08-06 18:21:44]

On 2013/08/06 17:37:22, reed1 wrote:
> if the tests still pass, lgtm

me too lgtm

[commit-bot: I haz the power, 2013-08-07 14:15:45]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/sglez@google.com/21949007/21001

[commit-bot: I haz the power, 2013-08-07 15:22:08]

Change committed as 10603

[robertphillips, 2013-08-07 22:37:34]

This was reverted in r10632 due to Chromium failures (e.g.,
http://108.170.217.252:10117/builders/Canary-Chrome-Ubuntu12-Ninja-x86_64-Def...)