Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7733)

Unified Diff: chrome/browser/prerender/prerender_tab_helper.cc

Issue 21948003: Add instrumentation to detect the type of login actions being added. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_tab_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_tab_helper.cc
===================================================================
--- chrome/browser/prerender/prerender_tab_helper.cc (revision 215333)
+++ chrome/browser/prerender/prerender_tab_helper.cc (working copy)
@@ -250,6 +250,15 @@
if (params.password_form.origin.is_valid() && prerender_manager) {
prerender_manager->RecordLikelyLoginOnURL(params.url);
RecordEvent(EVENT_LOGIN_ACTION_ADDED);
+ if (details.is_main_frame) {
+ RecordEvent(EVENT_LOGIN_ACTION_ADDED_MAINFRAME);
+ if (params.password_form.password_value.empty())
+ RecordEvent(EVENT_LOGIN_ACTION_ADDED_MAINFRAME_PW_EMPTY);
+ } else {
+ RecordEvent(EVENT_LOGIN_ACTION_ADDED_SUBFRAME);
+ if (params.password_form.password_value.empty())
+ RecordEvent(EVENT_LOGIN_ACTION_ADDED_SUBFRAME_PW_EMPTY);
+ }
}
}
« no previous file with comments | « chrome/browser/prerender/prerender_tab_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698