Issue 21947003: [Autofill] Move FieldTypeGroup out of the AutofillType class.

Issue 21947003: [Autofill] Move FieldTypeGroup out of the AutofillType class. (Closed)

Created:
7 years, 4 months ago by Ilya Sherman

Modified:
7 years, 4 months ago

Reviewers:
aruslan, Evan Stade

CC:
chromium-reviews, Raman Kakilate, jam, benquan, tfarina, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Autofill] Move FieldTypeGroup out of the AutofillType class. The class name is longer needed for namespacing now that the code is in the autofill:: namespace R=estade@chromium.org TBR=aruslan@chromium.org BUG=none TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215778

Patch Set 1 #

Patch Set 2 : Fix #includes #

Patch Set 3 : Fix compile #

Patch Set 4 : More compile fixes. This is what I get for trying to split off a smaller CL from a giant one. #

Patch Set 5 : Rebase #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -87 lines)			Patch
M	chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/autofill/data_model_wrapper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_section_container.mm	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_dialog_views.cc	View	1 2 3 4	1 chunk	+2 lines, -3 lines	0 comments	Download
M	components/autofill/content/browser/autocheckout_manager.cc	View	1 2 3 4	3 chunks	+5 lines, -5 lines	0 comments	Download
M	components/autofill/content/browser/wallet/wallet_items.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/autofill/core/browser/autofill_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/autofill/core/browser/autofill_metrics.cc	View	1 2 3	2 chunks	+7 lines, -7 lines	0 comments	Download
M	components/autofill/core/browser/autofill_profile.cc	View	1 2	7 chunks	+27 lines, -27 lines	0 comments	Download
M	components/autofill/core/browser/autofill_type.h	View	1	3 chunks	+0 lines, -20 lines	0 comments	Download
M	components/autofill/core/browser/autofill_type_unittest.cc	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	components/autofill/core/browser/contact_info.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/autofill/core/browser/credit_card.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/autofill/core/browser/field_types.h	View	1	2 chunks	+17 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/form_structure.cc	View	1 2	2 chunks	+3 lines, -4 lines	0 comments	Download
M	components/autofill/core/browser/personal_data_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/21947003/13001

7 years, 4 months ago (2013-08-05 21:19:43 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=18849

7 years, 4 months ago (2013-08-05 21:36:01 UTC) #4

Ilya Sherman

Ruslan, TBR'ing you for trivial changes to Android code that I'm pretty sure you're in ...

7 years, 4 months ago (2013-08-05 22:00:45 UTC) #5

aruslan

On 2013/08/05 22:00:45, Ilya Sherman wrote: > Ruslan, TBR'ing you for trivial changes to Android ...

7 years, 4 months ago (2013-08-05 22:12:10 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/21947003/25001

7 years, 4 months ago (2013-08-05 22:46:00 UTC) #7

Message was sent while issue was closed.

Change committed as 215778

Expand Messages | Collapse Messages