content/browser/browser_plugin/browser_plugin_embedder.cc - Issue 21930006: <webview>: Allocate the view instance ID from the WebView shim

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 21930006: <webview>: Allocate the view instance ID from the WebView shim (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with ToT Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/web_view_experimental.js ('k') | content/common/browser_plugin/browser_plugin_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_embedder.cc

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc

index 5b7f5b18965790ffe54f1c37b8c4707309a32ff4..4a06aca32c9218af34b9c70c0184c66aeca76b75 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.cc

+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc

@@ -187,7 +187,6 @@ void BrowserPluginEmbedder::OnAttach(

GetContentClient()->browser()->GuestWebContentsAttached(

guest->GetWebContents(),

web_contents(),

- params.browser_plugin_instance_id,

extra_params);

guest->Attach(static_cast<WebContentsImpl*>(web_contents()), params);

return;

@@ -202,7 +201,6 @@ void BrowserPluginEmbedder::OnAttach(

GetContentClient()->browser()->GuestWebContentsAttached(

guest->GetWebContents(),

web_contents(),

- params.browser_plugin_instance_id,

extra_params);

guest->Initialize(static_cast<WebContentsImpl*>(web_contents()), params);

}