Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/guestview/webview/webview_guest.cc

Issue 21930006: <webview>: Allocate the view instance ID from the WebView shim (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with ToT Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guestview/webview/webview_guest.h ('k') | chrome/renderer/resources/extensions/web_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guestview/webview/webview_guest.cc
diff --git a/chrome/browser/guestview/webview/webview_guest.cc b/chrome/browser/guestview/webview/webview_guest.cc
index 9bd938950043abc7c591bc3bf080b1bc4bba0be4..dddf36f51bfdd37ce050d32dffac262a95d13525 100644
--- a/chrome/browser/guestview/webview/webview_guest.cc
+++ b/chrome/browser/guestview/webview/webview_guest.cc
@@ -80,10 +80,9 @@ WebViewGuest* WebViewGuest::From(int embedder_process_id,
void WebViewGuest::Attach(WebContents* embedder_web_contents,
const std::string& extension_id,
- int view_instance_id,
const base::DictionaryValue& args) {
GuestView::Attach(
- embedder_web_contents, extension_id, view_instance_id, args);
+ embedder_web_contents, extension_id, args);
AddWebViewToExtensionRendererState();
}
@@ -317,7 +316,6 @@ void WebViewGuest::AddWebViewToExtensionRendererState() {
ExtensionRendererState::WebViewInfo webview_info;
webview_info.embedder_process_id = embedder_render_process_id();
webview_info.embedder_routing_id = embedder_web_contents()->GetRoutingID();
- webview_info.guest_instance_id = guest_instance_id();
webview_info.instance_id = view_instance_id();
content::BrowserThread::PostTask(
« no previous file with comments | « chrome/browser/guestview/webview/webview_guest.h ('k') | chrome/renderer/resources/extensions/web_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698