Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3160)

Unified Diff: chrome/browser/guestview/guestview.cc

Issue 21930006: <webview>: Allocate the view instance ID from the WebView shim (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with ToT Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guestview/guestview.h ('k') | chrome/browser/guestview/guestview_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guestview/guestview.cc
diff --git a/chrome/browser/guestview/guestview.cc b/chrome/browser/guestview/guestview.cc
index 502f6db9bc90b35017569cac7041b2c90831d80a..414962ecdbef333d74816307ab06a8d37256f808 100644
--- a/chrome/browser/guestview/guestview.cc
+++ b/chrome/browser/guestview/guestview.cc
@@ -67,13 +67,12 @@ GuestView* GuestView::From(int embedder_process_id, int guest_instance_id) {
void GuestView::Attach(content::WebContents* embedder_web_contents,
const std::string& extension_id,
- int view_instance_id,
const base::DictionaryValue& args) {
embedder_web_contents_ = embedder_web_contents;
embedder_render_process_id_ =
embedder_web_contents->GetRenderProcessHost()->GetID();
extension_id_ = extension_id;
- view_instance_id_ = view_instance_id;
+ args.GetInteger(guestview::kParameterInstanceId, &view_instance_id_);
std::pair<int, int> key(embedder_render_process_id_, guest_instance_id_);
embedder_guestview_map.Get().insert(std::make_pair(key, this));
« no previous file with comments | « chrome/browser/guestview/guestview.h ('k') | chrome/browser/guestview/guestview_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698