Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2192803002: Refactoring: Remove unused member functions in MemoryCache (Closed)

Created:
4 years, 4 months ago by hajimehoshi
Modified:
4 years, 4 months ago
Reviewers:
hiroshige, Mike West
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Remove unused member functions in MemoryCache This CL removes unused member functions in MemoryCache for code health. BUG=n/a TEST=n/a Committed: https://crrev.com/b14ba0e905a27e49126e3c48cfd7609cee56c310 Cr-Commit-Position: refs/heads/master@{#408951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
hajimehoshi
PTAL
4 years, 4 months ago (2016-07-28 09:30:21 UTC) #2
hiroshige
lgtm
4 years, 4 months ago (2016-07-28 09:35:27 UTC) #4
Mike West
LGTM. Was there no corresponding definition to remove?
4 years, 4 months ago (2016-08-01 11:47:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192803002/1
4 years, 4 months ago (2016-08-01 11:49:55 UTC) #7
hajimehoshi
On 2016/08/01 11:47:23, Mike West wrote: > LGTM. Was there no corresponding definition to remove? ...
4 years, 4 months ago (2016-08-01 11:50:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 13:15:11 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 13:17:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b14ba0e905a27e49126e3c48cfd7609cee56c310
Cr-Commit-Position: refs/heads/master@{#408951}

Powered by Google App Engine
This is Rietveld 408576698