Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

Issue 2191633003: Move ResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-raw-resource-client
Patch Set: build fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
index 37374b3f87fd81d7c34ddc9fc9cb5b58993b5817..26ac26643ac87e812fce90a9e2cb9de9b7bcba8c 100644
--- a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
@@ -160,7 +160,7 @@ TEST(RawResourceTest, RevalidationSucceeded)
memoryCache()->remove(resource);
resource->removeClient(client);
- EXPECT_FALSE(resource->hasClientsOrObservers());
+ EXPECT_FALSE(resource->isAlive());
EXPECT_FALSE(client->called());
EXPECT_EQ("abcd", String(client->data().data(), client->data().size()));
}
@@ -190,7 +190,7 @@ TEST(RawResourceTest, RevalidationSucceededForResourceWithoutBody)
memoryCache()->remove(resource);
resource->removeClient(client);
- EXPECT_FALSE(resource->hasClientsOrObservers());
+ EXPECT_FALSE(resource->isAlive());
EXPECT_FALSE(client->called());
EXPECT_EQ(0u, client->data().size());
}
@@ -253,7 +253,7 @@ TEST(RawResourceTest, RevalidationSucceededUpdateHeaders)
memoryCache()->remove(resource);
resource->removeClient(client);
- EXPECT_FALSE(resource->hasClientsOrObservers());
+ EXPECT_FALSE(resource->isAlive());
EXPECT_FALSE(client->called());
EXPECT_EQ(0u, client->data().size());
}
@@ -330,7 +330,7 @@ TEST(RawResourceTest, RedirectDuringRevalidation)
resource->removeClient(client);
resource->removeClient(client2);
- EXPECT_FALSE(resource->hasClientsOrObservers());
+ EXPECT_FALSE(resource->isAlive());
}
TEST(RawResourceTest, AddClientDuringCallback)
@@ -350,7 +350,7 @@ TEST(RawResourceTest, AddClientDuringCallback)
testing::runPendingTasks();
raw->removeClient(addingClient);
EXPECT_FALSE(dummyClient->called());
- EXPECT_FALSE(raw->hasClientsOrObservers());
+ EXPECT_FALSE(raw->isAlive());
}
// This client removes another client when notified.
@@ -395,7 +395,7 @@ TEST(RawResourceTest, RemoveClientDuringCallback)
raw->addClient(dummyClient);
raw->addClient(removingClient);
testing::runPendingTasks();
- EXPECT_FALSE(raw->hasClientsOrObservers());
+ EXPECT_FALSE(raw->isAlive());
}
TEST(RawResourceTest, CanReuseDevToolsEmulateNetworkConditionsClientIdHeader)
« no previous file with comments | « third_party/WebKit/Source/core/fetch/RawResource.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698