third_party/WebKit/Source/core/fetch/RawResource.h - Issue 2191633003: Move ResourceClient to Oilpan heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/RawResource.h

Issue 2191633003: Move ResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-raw-resource-client

Patch Set: build fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/MockResourceClients.cpp ('k') | third_party/WebKit/Source/core/fetch/RawResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/RawResource.h

diff --git a/third_party/WebKit/Source/core/fetch/RawResource.h b/third_party/WebKit/Source/core/fetch/RawResource.h

index 9dfa986d62a49b88ce052d8b4cac01af75c665a3..2a5037ff67710263174790aa6738ff2e67ace955 100644

--- a/third_party/WebKit/Source/core/fetch/RawResource.h

+++ b/third_party/WebKit/Source/core/fetch/RawResource.h

@@ -102,7 +102,7 @@ inline RawResource* toRawResource(Resource* resource)

return static_cast<RawResource*>(resource);

}

-class CORE_EXPORT RawResourceClient : public GarbageCollectedMixin, public ResourceClient {

+class CORE_EXPORT RawResourceClient : public ResourceClient {

public:

static bool isExpectedType(ResourceClient* client) { return client->getResourceClientType() == RawResourceType; }

ResourceClientType getResourceClientType() const final { return RawResourceType; }

@@ -132,8 +132,6 @@ public:

virtual void redirectBlocked() {}

virtual void dataDownloaded(Resource*, int) { }

virtual void didReceiveResourceTiming(Resource*, const ResourceTimingInfo&) { }

- DEFINE_INLINE_VIRTUAL_TRACE() {}

};

// Checks the sequence of callbacks of RawResourceClient.