Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

Issue 2191633003: Move ResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-raw-resource-client
Patch Set: build fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
index 6c22c275962239c8acea93b4864d12be8f1b6e08..01ba228ed9ad34893455bd69a19678a107fda2f6 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
@@ -299,7 +299,7 @@ TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)
// The prune comes when the ImageResource still has clients. The image should not be deleted.
cachedImage->prune();
- ASSERT_TRUE(cachedImage->hasClientsOrObservers());
+ ASSERT_TRUE(cachedImage->isAlive());
ASSERT_TRUE(cachedImage->hasImage());
ASSERT_FALSE(cachedImage->getImage()->isNull());
@@ -307,7 +307,7 @@ TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)
// deleted by prune.
client->removeAsClient();
cachedImage->prune();
- ASSERT_FALSE(cachedImage->hasClientsOrObservers());
+ ASSERT_FALSE(cachedImage->isAlive());
ASSERT_TRUE(cachedImage->hasImage());
// TODO(hajimehoshi): Should check cachedImage doesn't have decoded image
// data.
@@ -605,7 +605,7 @@ TEST(ImageResourceTest, AddClientAfterPrune)
client1->removeAsClient();
- EXPECT_FALSE(imageResource->hasClientsOrObservers());
+ EXPECT_FALSE(imageResource->isAlive());
imageResource->prune();
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/MemoryCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698