Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ResourceClientWalker.h

Issue 2191633003: Move ResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-raw-resource-client
Patch Set: build fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 4 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
5 5
6 This library is free software; you can redistribute it and/or 6 This library is free software; you can redistribute it and/or
7 modify it under the terms of the GNU Library General Public 7 modify it under the terms of the GNU Library General Public
8 License as published by the Free Software Foundation; either 8 License as published by the Free Software Foundation; either
9 version 2 of the License, or (at your option) any later version. 9 version 2 of the License, or (at your option) any later version.
10 10
11 This library is distributed in the hope that it will be useful, 11 This library is distributed in the hope that it will be useful,
12 but WITHOUT ANY WARRANTY; without even the implied warranty of 12 but WITHOUT ANY WARRANTY; without even the implied warranty of
13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 Library General Public License for more details. 14 Library General Public License for more details.
15 15
16 You should have received a copy of the GNU Library General Public License 16 You should have received a copy of the GNU Library General Public License
17 along with this library; see the file COPYING.LIB. If not, write to 17 along with this library; see the file COPYING.LIB. If not, write to
18 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 18 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 Boston, MA 02110-1301, USA. 19 Boston, MA 02110-1301, USA.
20 20
21 This class provides all functionality needed for loading images, style sheet s and html 21 This class provides all functionality needed for loading images, style sheet s and html
22 pages from the web. It has a memory cache for these objects. 22 pages from the web. It has a memory cache for these objects.
23 */ 23 */
24 24
25 #ifndef ResourceClientOrObserverWalker_h 25 #ifndef ResourceClientWalker_h
26 #define ResourceClientOrObserverWalker_h 26 #define ResourceClientWalker_h
27 27
28 #include "core/fetch/ResourceClient.h" 28 #include "core/fetch/ResourceClient.h"
29 #include "platform/heap/Handle.h"
29 #include "wtf/Allocator.h" 30 #include "wtf/Allocator.h"
30 #include "wtf/HashCountedSet.h"
31 #include "wtf/Vector.h"
32 31
33 namespace blink { 32 namespace blink {
34 33
35 // Call this "walker" instead of iterator so people won't expect Qt or STL-style iterator interface. 34 // Call this "walker" instead of iterator so people won't expect Qt or STL-style iterator interface.
36 // Just keep calling next() on this. It's safe from deletions of items. 35 // Just keep calling next() on this. It's safe from deletions of items.
37 // ClientOrObserver is either ResourceClient or ImageResourceObserver, so that 36 template <typename T>
38 // this walker can be used both for ResourceClient and ImageResourceObserver. 37 class ResourceClientWalker {
39 template<typename ClientOrObserver, typename T>
40 class ResourceClientOrObserverWalker {
41 STACK_ALLOCATED(); 38 STACK_ALLOCATED();
42 public: 39 public:
43 explicit ResourceClientOrObserverWalker(const HashCountedSet<ClientOrObserve r*>& set) 40 explicit ResourceClientWalker(const HeapHashCountedSet<WeakMember<ResourceCl ient>>& set)
44 : m_clientSet(set), m_clientVector(set.size()), m_index(0) 41 : m_clientSet(set)
45 { 42 {
46 size_t clientIndex = 0; 43 copyToVector(m_clientSet, m_clientVector);
47 for (const auto& resourceClient : set)
48 m_clientVector[clientIndex++] = resourceClient.key;
49 } 44 }
50 45
51 T* next() 46 T* next()
52 { 47 {
53 size_t size = m_clientVector.size(); 48 size_t size = m_clientVector.size();
54 while (m_index < size) { 49 while (m_index < size) {
55 ClientOrObserver* next = m_clientVector[m_index++]; 50 ResourceClient* next = m_clientVector[m_index++];
51 DCHECK(next);
56 if (m_clientSet.contains(next)) { 52 if (m_clientSet.contains(next)) {
57 ASSERT(T::isExpectedType(next)); 53 DCHECK(T::isExpectedType(next));
58 return static_cast<T*>(next); 54 return static_cast<T*>(next);
59 } 55 }
60 } 56 }
57 return nullptr;
58 }
61 59
62 return 0;
63 }
64 private: 60 private:
65 const HashCountedSet<ClientOrObserver*>& m_clientSet; 61 const HeapHashCountedSet<WeakMember<ResourceClient>>& m_clientSet;
66 Vector<ClientOrObserver*> m_clientVector; 62 HeapVector<Member<ResourceClient>> m_clientVector;
67 size_t m_index; 63 size_t m_index = 0;
68 };
69
70 template<typename T>
71 struct ResourceClientWalker : public ResourceClientOrObserverWalker<ResourceClie nt, T> {
72 public:
73 explicit ResourceClientWalker(const HashCountedSet<ResourceClient*>& set)
74 : ResourceClientOrObserverWalker<ResourceClient, T>(set) { }
75 }; 64 };
76 65
77 } // namespace blink 66 } // namespace blink
78 67
79 #endif 68 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698