Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 21916003: GCP2.0 Device: XMPP pings. (Closed)

Created:
7 years, 4 months ago by maksymb
Modified:
7 years, 4 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@xmpp
Visibility:
Public.

Description

GCP2.0 Device: XMPP pings. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216107

Patch Set 1 #

Patch Set 2 : Extended intervals #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -14 lines) Patch
M cloud_print/gcp20/prototype/cloud_print_xmpp_listener.h View 5 chunks +36 lines, -6 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc View 1 2 3 6 chunks +84 lines, -6 lines 0 comments Download
M cloud_print/gcp20/prototype/printer.cc View 1 2 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
maksymb
138 lines
7 years, 4 months ago (2013-08-02 19:17:42 UTC) #1
gene
lgtm, nit below https://chromiumcodereview.appspot.com/21916003/diff/12001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc File cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc (right): https://chromiumcodereview.appspot.com/21916003/diff/12001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc#newcode18 cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc:18: const int kUrgentPingInterval = 60; // ...
7 years, 4 months ago (2013-08-06 20:05:06 UTC) #2
maksymb
https://codereview.chromium.org/21916003/diff/12001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc File cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc (right): https://codereview.chromium.org/21916003/diff/12001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc#newcode18 cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc:18: const int kUrgentPingInterval = 60; // in seconds On ...
7 years, 4 months ago (2013-08-06 20:27:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maksymb@chromium.org/21916003/18001
7 years, 4 months ago (2013-08-06 20:28:03 UTC) #4
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=91337
7 years, 4 months ago (2013-08-07 02:34:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maksymb@chromium.org/21916003/18001
7 years, 4 months ago (2013-08-07 02:41:41 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-07 06:01:31 UTC) #7
Message was sent while issue was closed.
Change committed as 216107

Powered by Google App Engine
This is Rietveld 408576698