chrome/browser/extensions/api/web_request/web_request_api_helpers.cc - Issue 21907006: Fix invalid parsing of cookie in Web request helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

Issue 21907006: Fix invalid parsing of cookie in Web request helpers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unittest Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

index 058f122f790c2686051bb55e6b2be678bd4b1d42..5c10c8d1c1fa0ec606427e8e7d2d9dc69dc2ef26 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

@@ -498,6 +498,7 @@ static void ParseRequestCookieLine(

++i; // Skip '='.

std::string::const_iterator cookie_value_beginning = i;

if (*i == '"') {

+ ++i; // Skip '"'.

while (i != header_value.end() && *i != '"') ++i;

if (i == header_value.end()) return;

++i; // Skip '"'.

« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_request/web_request_api_unittest.cc » ('j') | no next file with comments »