Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: ash/common/system/chromeos/session/logout_button_tray.cc

Issue 2190453002: Update CrOS logout button for MD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix override Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/views/controls/button/label_button.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/system/chromeos/session/logout_button_tray.h" 5 #include "ash/common/system/chromeos/session/logout_button_tray.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "ash/common/material_design/material_design_controller.h"
10 #include "ash/common/shelf/shelf_types.h" 11 #include "ash/common/shelf/shelf_types.h"
11 #include "ash/common/system/chromeos/session/logout_confirmation_controller.h" 12 #include "ash/common/system/chromeos/session/logout_confirmation_controller.h"
12 #include "ash/common/system/tray/system_tray_delegate.h" 13 #include "ash/common/system/tray/system_tray_delegate.h"
13 #include "ash/common/system/tray/system_tray_notifier.h" 14 #include "ash/common/system/tray/system_tray_notifier.h"
14 #include "ash/common/system/tray/tray_constants.h" 15 #include "ash/common/system/tray/tray_constants.h"
15 #include "ash/common/system/tray/tray_utils.h" 16 #include "ash/common/system/tray/tray_utils.h"
16 #include "ash/common/system/user/login_status.h" 17 #include "ash/common/system/user/login_status.h"
17 #include "ash/common/wm_shell.h" 18 #include "ash/common/wm_shell.h"
18 #include "base/logging.h" 19 #include "base/logging.h"
19 #include "grit/ash_resources.h" 20 #include "grit/ash_resources.h"
20 #include "third_party/skia/include/core/SkColor.h" 21 #include "third_party/skia/include/core/SkColor.h"
21 #include "ui/events/event.h" 22 #include "ui/events/event.h"
23 #include "ui/gfx/color_palette.h"
22 #include "ui/gfx/geometry/insets.h" 24 #include "ui/gfx/geometry/insets.h"
23 #include "ui/gfx/geometry/size.h" 25 #include "ui/gfx/geometry/size.h"
24 #include "ui/views/bubble/tray_bubble_view.h" 26 #include "ui/views/bubble/tray_bubble_view.h"
25 #include "ui/views/controls/button/label_button.h" 27 #include "ui/views/controls/button/label_button.h"
26 #include "ui/views/controls/button/label_button_border.h" 28 #include "ui/views/controls/button/label_button_border.h"
29 #include "ui/views/controls/button/md_text_button.h"
27 #include "ui/views/painter.h" 30 #include "ui/views/painter.h"
28 31
29 namespace ash { 32 namespace ash {
30 namespace { 33 namespace {
31 34
32 const int kLogoutButtonHorizontalExtraPadding = 7; 35 const int kLogoutButtonHorizontalExtraPadding = 7;
33 36
34 const int kLogoutButtonNormalImages[] = { 37 const int kLogoutButtonNormalImages[] = {
35 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_TOP_LEFT, 38 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_TOP_LEFT,
36 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_TOP, 39 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_TOP,
37 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_TOP_RIGHT, 40 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_TOP_RIGHT,
38 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_LEFT, 41 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_LEFT,
39 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_CENTER, 42 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_CENTER,
40 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_RIGHT, 43 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_RIGHT,
41 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_BOTTOM_LEFT, 44 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_BOTTOM_LEFT,
42 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_BOTTOM, 45 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_BOTTOM,
43 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_BOTTOM_RIGHT}; 46 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_NORMAL_BOTTOM_RIGHT};
44 47
45 const int kLogoutButtonPushedImages[] = { 48 const int kLogoutButtonPushedImages[] = {
46 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_TOP_LEFT, 49 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_TOP_LEFT,
47 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_TOP, 50 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_TOP,
48 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_TOP_RIGHT, 51 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_TOP_RIGHT,
49 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_LEFT, 52 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_LEFT,
50 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_CENTER, 53 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_CENTER,
51 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_RIGHT, 54 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_RIGHT,
52 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_BOTTOM_LEFT, 55 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_BOTTOM_LEFT,
53 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_BOTTOM, 56 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_BOTTOM,
54 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_BOTTOM_RIGHT}; 57 IDR_AURA_UBER_TRAY_LOGOUT_BUTTON_PUSHED_BOTTOM_RIGHT};
55 58
59 // TODO(estade): LogoutButton is not used in MD; remove it when possible.
60 // See crbug.com/614453
56 class LogoutButton : public views::LabelButton { 61 class LogoutButton : public views::LabelButton {
57 public: 62 public:
58 LogoutButton(views::ButtonListener* listener); 63 LogoutButton(views::ButtonListener* listener);
59 ~LogoutButton() override; 64 ~LogoutButton() override;
60 65
61 private: 66 private:
62 DISALLOW_COPY_AND_ASSIGN(LogoutButton); 67 DISALLOW_COPY_AND_ASSIGN(LogoutButton);
63 }; 68 };
64 69
65 } // namespace 70 } // namespace
(...skipping 22 matching lines...) Expand all
88 SetBorder(std::move(border)); 93 SetBorder(std::move(border));
89 set_animate_on_state_change(false); 94 set_animate_on_state_change(false);
90 95
91 SetMinSize(gfx::Size(0, GetTrayConstant(TRAY_ITEM_HEIGHT_LEGACY))); 96 SetMinSize(gfx::Size(0, GetTrayConstant(TRAY_ITEM_HEIGHT_LEGACY)));
92 } 97 }
93 98
94 LogoutButton::~LogoutButton() {} 99 LogoutButton::~LogoutButton() {}
95 100
96 LogoutButtonTray::LogoutButtonTray(WmShelf* wm_shelf) 101 LogoutButtonTray::LogoutButtonTray(WmShelf* wm_shelf)
97 : TrayBackgroundView(wm_shelf), 102 : TrayBackgroundView(wm_shelf),
98 button_(NULL), 103 button_(nullptr),
99 login_status_(LoginStatus::NOT_LOGGED_IN), 104 login_status_(LoginStatus::NOT_LOGGED_IN),
100 show_logout_button_in_tray_(false) { 105 show_logout_button_in_tray_(false) {
101 button_ = new LogoutButton(this); 106 if (MaterialDesignController::IsShelfMaterial()) {
107 views::MdTextButton* button =
108 views::MdTextButton::CreateMdButton(this, base::string16());
109 button->SetCallToAction(true);
110 button->set_bg_color_override(gfx::kGoogleRed700);
111 // Base font size + 2 = 14.
112 // TODO(estade): should this 2 be shared with other tray views? See
113 // crbug.com/623987
114 button->AdjustFontSize(2);
115 button->SetMinSize(gfx::Size(0, kTrayItemSize));
116 button_ = button;
117 } else {
118 button_ = new LogoutButton(this);
119 }
102 tray_container()->AddChildView(button_); 120 tray_container()->AddChildView(button_);
103 tray_container()->SetBorder(views::Border::NullBorder()); 121 tray_container()->SetBorder(views::Border::NullBorder());
104 WmShell::Get()->system_tray_notifier()->AddLogoutButtonObserver(this); 122 WmShell::Get()->system_tray_notifier()->AddLogoutButtonObserver(this);
105 } 123 }
106 124
107 LogoutButtonTray::~LogoutButtonTray() { 125 LogoutButtonTray::~LogoutButtonTray() {
108 WmShell::Get()->system_tray_notifier()->RemoveLogoutButtonObserver(this); 126 WmShell::Get()->system_tray_notifier()->RemoveLogoutButtonObserver(this);
109 } 127 }
110 128
111 void LogoutButtonTray::SetShelfAlignment(ShelfAlignment alignment) { 129 void LogoutButtonTray::SetShelfAlignment(ShelfAlignment alignment) {
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 UpdateVisibility(); 170 UpdateVisibility();
153 } 171 }
154 172
155 void LogoutButtonTray::UpdateVisibility() { 173 void LogoutButtonTray::UpdateVisibility() {
156 SetVisible(show_logout_button_in_tray_ && 174 SetVisible(show_logout_button_in_tray_ &&
157 login_status_ != LoginStatus::NOT_LOGGED_IN && 175 login_status_ != LoginStatus::NOT_LOGGED_IN &&
158 login_status_ != LoginStatus::LOCKED); 176 login_status_ != LoginStatus::LOCKED);
159 } 177 }
160 178
161 } // namespace ash 179 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | ui/views/controls/button/label_button.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698