Add for attributes to labels on 'Pack Extension' overlay

Add for attributes to labels on 'Pack Extension' overlay 

BUG=265583
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215777

[Dan Beam, 2013-08-02 20:44:38]

any reason why the labels aren't wrapping the input?

[aboxhall, 2013-08-02 20:53:48]

On 2013/08/02 20:44:38, Dan Beam wrote:
> any reason why the labels aren't wrapping the input?

Either way works: http://www.html5accessibility.com/tests/form-labels.html
Would you prefer them to be wrapped?

[Dan Beam, 2013-08-02 22:04:25]

On 2013/08/02 20:53:48, aboxhall wrote:
> On 2013/08/02 20:44:38, Dan Beam wrote:
> > any reason why the labels aren't wrapping the input?
> 
> Either way works: http://www.html5accessibility.com/tests/form-labels.html
> Would you prefer them to be wrapped?

assuming they're functionally equivalent, yes -- less code and doesn't need to
be kept in sync

[aboxhall, 2013-08-05 19:12:42]

On 2013/08/02 22:04:25, Dan Beam wrote:
> On 2013/08/02 20:53:48, aboxhall wrote:
> > On 2013/08/02 20:44:38, Dan Beam wrote:
> > > any reason why the labels aren't wrapping the input?
> > 
> > Either way works: http://www.html5accessibility.com/tests/form-labels.html
> > Would you prefer them to be wrapped?
> 
> assuming they're functionally equivalent, yes -- less code and doesn't need to
> be kept in sync

Done.

[aboxhall, 2013-08-05 20:17:27]

On 2013/08/05 19:12:42, aboxhall wrote:
> On 2013/08/02 22:04:25, Dan Beam wrote:
> > On 2013/08/02 20:53:48, aboxhall wrote:
> > > On 2013/08/02 20:44:38, Dan Beam wrote:
> > > > any reason why the labels aren't wrapping the input?
> > > 
> > > Either way works: http://www.html5accessibility.com/tests/form-labels.html
> > > Would you prefer them to be wrapped?
> > 
> > assuming they're functionally equivalent, yes -- less code and doesn't need
to
> > be kept in sync
> 
> Done.

Actually, after double-checking this, it's clear that wrapping the input element
won't work: the i18n-content attribute causes all of the label's inner content
to be overwritten with the internationalised content, including the input
element.

Reverted to using for/id, and checked using ChromeVox.

[Dan Beam, 2013-08-05 20:30:49]

https://codereview.chromium.org/21884004/diff/13001/chrome/browser/resources/...
File chrome/browser/resources/extensions/pack_extension_overlay.html (right):

https://codereview.chromium.org/21884004/diff/13001/chrome/browser/resources/...
chrome/browser/resources/extensions/pack_extension_overlay.html:13: <label
i18n-content="packExtensionPrivateKey" for="extensionPrivateKey"></label>
80 col wrap

https://codereview.chromium.org/21884004/diff/13001/chrome/browser/resources/...
chrome/browser/resources/extensions/pack_extension_overlay.html:16: 
nit: revert

[aboxhall, 2013-08-05 20:40:56]

https://codereview.chromium.org/21884004/diff/13001/chrome/browser/resources/...
File chrome/browser/resources/extensions/pack_extension_overlay.html (right):

https://codereview.chromium.org/21884004/diff/13001/chrome/browser/resources/...
chrome/browser/resources/extensions/pack_extension_overlay.html:13: <label
i18n-content="packExtensionPrivateKey" for="extensionPrivateKey"></label>
On 2013/08/05 20:30:49, Dan Beam wrote:
> 80 col wrap

Done.

https://codereview.chromium.org/21884004/diff/13001/chrome/browser/resources/...
chrome/browser/resources/extensions/pack_extension_overlay.html:16: 
On 2013/08/05 20:30:49, Dan Beam wrote:
> nit: revert

Done.

[Dan Beam, 2013-08-05 21:34:09]

lgtm

[commit-bot: I haz the power, 2013-08-05 21:40:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/21884004/18001

[commit-bot: I haz the power, 2013-08-05 21:57:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/21884004/18001

[commit-bot: I haz the power, 2013-08-06 03:07:45]

Change committed as 215777