Issue 21878002: Don't enable asynchronous browser startup when running layout tests.

Issue 21878002: Don't enable asynchronous browser startup when running layout tests. (Closed)

Created:
7 years, 4 months ago by Peter Beverloo

Modified:
7 years, 4 months ago

Reviewers:
aberent, bulach, Yaron

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't enable asynchronous browser startup when running layout tests. Layout tests are unable to get the browser context when this mode, introduced in r215042, has been enabled, and crash somewhere deep down the stack. BUG=267522 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215955

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -12 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/common/CommandLine.java	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java	View		1 chunk	+14 lines, -12 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Peter Beverloo

With thanks to Anthony for identifying this work-around!

7 years, 4 months ago (2013-08-02 14:56:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/21878002/1

7 years, 4 months ago (2013-08-02 15:05:00 UTC) #4

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=18466

7 years, 4 months ago (2013-08-02 15:19:26 UTC) #5

Peter Beverloo

+yfriedman for OWNERS.. Mind checking the CQ button if you're happy?

7 years, 4 months ago (2013-08-02 15:24:38 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/21878002/1

7 years, 4 months ago (2013-08-06 17:24:57 UTC) #8

Message was sent while issue was closed.

Change committed as 215955

Expand Messages | Collapse Messages