Issue 21877006: Add blend optimization helpers and use to convert rect draws to clears.

Issue 21877006: Add blend optimization helpers and use to convert rect draws to clears. (Closed)

Created:
7 years, 4 months ago by bsalomon

Modified:
7 years, 4 months ago

Reviewers:
jvanverth1, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add blend optimization helpers and use to convert rect draws to clears. Committed: http://code.google.com/p/skia/source/detail?r=10537 Committed: http://code.google.com/p/skia/source/detail?r=10562

Patch Set 3 : incorporate review comments #

Patch Set 4 : change src to rect in comment #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+358 lines, -60 lines)			Patch
M	gyp/gpu.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkMatrix.h	View	1 2 3	1 chunk	+12 lines, -0 lines	0 comments	Download
M	include/core/SkRect.h	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	include/gpu/GrPaint.h	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	include/gpu/GrSurface.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
A	src/gpu/GrBlend.h	View		1 chunk	+45 lines, -0 lines	0 comments	Download
A	src/gpu/GrBlend.cpp	View		1 chunk	+154 lines, -0 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View		4 chunks	+52 lines, -38 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View		2 chunks	+5 lines, -20 lines	0 comments	Download
M	src/gpu/GrPaint.cpp	View		2 chunks	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

jvanverth1

lgtm + one comment https://codereview.chromium.org/21877006/diff/2001/src/gpu/GrBlend.cpp File src/gpu/GrBlend.cpp (right): https://codereview.chromium.org/21877006/diff/2001/src/gpu/GrBlend.cpp#newcode142 src/gpu/GrBlend.cpp:142: GrBlendCoeff spoofedCoeff = swap_coeff_src_dst(*dstCoeff); This ...

7 years, 4 months ago (2013-08-02 21:30:28 UTC) #2

robertphillips

lgtm + 1 nit & 1 questions https://codereview.chromium.org/21877006/diff/2001/include/core/SkMatrix.h File include/core/SkMatrix.h (right): https://codereview.chromium.org/21877006/diff/2001/include/core/SkMatrix.h#newcode476 include/core/SkMatrix.h:476: @param dst ...

7 years, 4 months ago (2013-08-05 13:55:12 UTC) #3

reed1

lgtm w/ const nit https://codereview.chromium.org/21877006/diff/2001/include/core/SkMatrix.h File include/core/SkMatrix.h (right): https://codereview.chromium.org/21877006/diff/2001/include/core/SkMatrix.h#newcode479 include/core/SkMatrix.h:479: void mapRectToQuad(SkPoint dst[4], const SkRect& ...

7 years, 4 months ago (2013-08-05 14:56:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/21877006/15001

7 years, 4 months ago (2013-08-05 16:47:41 UTC) #7

bsalomon

On 2013/08/05 16:56:08, I haz the power (commit-bot) wrote: > Change committed as 10537 I ...

7 years, 4 months ago (2013-08-06 15:06:43 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/21877006/15001

7 years, 4 months ago (2013-08-06 15:06:54 UTC) #10

Message was sent while issue was closed.

Change committed as 10562

Expand Messages | Collapse Messages