Issue 21874003: Fixes twice-IME-committement on blur.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21874003: Fixes twice-IME-committement on blur. (Closed)

Created:
7 years, 4 months ago by Yuki

Modified:
7 years, 4 months ago

Reviewers:
Seigo Nonaka, yukawa, Yohei Yukawa

CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fixes twice-IME-committement on blur. This CL clears composition data in IME in InputMethodBridge::OnBlur. The cause was that ConfirmComposition called in InputMethodBridge::OnBlue doesn't clear IME's composition, and it will be committed again in host_->SetFocusedTextInputClient(NULL) in case of IMM32. BUG=265928 TEST=Test manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215803

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	ui/views/ime/input_method_bridge.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/21874003/1

7 years, 4 months ago (2013-08-05 16:42:58 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=156184

7 years, 4 months ago (2013-08-05 17:39:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/21874003/1

7 years, 4 months ago (2013-08-06 03:11:13 UTC) #6

Message was sent while issue was closed.

Change committed as 215803

Expand Messages | Collapse Messages