Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

Issue 2184263003: Move RawResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-threadable-loader
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
index 973137c1a7f23c9cb077d2c28cd7d6869a3e9c01..37374b3f87fd81d7c34ddc9fc9cb5b58993b5817 100644
--- a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
@@ -58,6 +58,7 @@ TEST(RawResourceTest, DontIgnoreAcceptForCacheReuse)
}
class DummyClient final : public GarbageCollectedFinalized<DummyClient>, public RawResourceClient {
+ USING_GARBAGE_COLLECTED_MIXIN(DummyClient);
public:
DummyClient() : m_called(false), m_numberOfRedirectsReceived(0) {}
~DummyClient() override {}
@@ -82,7 +83,10 @@ public:
bool called() { return m_called; }
int numberOfRedirectsReceived() const { return m_numberOfRedirectsReceived; }
const Vector<char>& data() { return m_data; }
- DEFINE_INLINE_TRACE() {}
+ DEFINE_INLINE_TRACE()
+ {
+ RawResourceClient::trace(visitor);
+ }
private:
bool m_called;
@@ -92,6 +96,7 @@ private:
// This client adds another client when notified.
class AddingClient final : public GarbageCollectedFinalized<AddingClient>, public RawResourceClient {
+ USING_GARBAGE_COLLECTED_MIXIN(AddingClient);
public:
AddingClient(DummyClient* client, Resource* resource)
: m_dummyClient(client)
@@ -119,6 +124,7 @@ public:
{
visitor->trace(m_dummyClient);
visitor->trace(m_resource);
+ RawResourceClient::trace(visitor);
}
private:
@@ -349,6 +355,7 @@ TEST(RawResourceTest, AddClientDuringCallback)
// This client removes another client when notified.
class RemovingClient : public GarbageCollectedFinalized<RemovingClient>, public RawResourceClient {
+ USING_GARBAGE_COLLECTED_MIXIN(RemovingClient);
public:
RemovingClient(DummyClient* client)
: m_dummyClient(client) {}
@@ -365,6 +372,7 @@ public:
DEFINE_INLINE_TRACE()
{
visitor->trace(m_dummyClient);
+ RawResourceClient::trace(visitor);
}
private:
« no previous file with comments | « third_party/WebKit/Source/core/fetch/RawResource.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698