Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 21835006: Change imm32_manager_ using scoped_ptr for mock testing. (Closed)

Created:
7 years, 4 months ago by yoichio
Modified:
7 years, 4 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, kochi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Change imm32_manager_ using scoped_ptr for mock testing. We will add Imm32Manager mocking test. BUG=244688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M content/browser/renderer_host/render_widget_host_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 15 chunks +23 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yoichio
This cl just changes to scoped_ptr. Please review.
7 years, 4 months ago (2013-08-05 05:08:31 UTC) #1
Yohei Yukawa
lgtm
7 years, 4 months ago (2013-08-05 05:14:22 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-05 06:21:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/21835006/1
7 years, 4 months ago (2013-08-05 06:27:44 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-05 10:19:32 UTC) #5
Message was sent while issue was closed.
Change committed as 215590

Powered by Google App Engine
This is Rietveld 408576698