Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2183323005: Make Resource::m_response private (Closed)

Created:
4 years, 4 months ago by hajimehoshi
Modified:
4 years, 4 months ago
Reviewers:
hiroshige, Mike West
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Resource::m_response private This CL makes |Resource::m_response| private and replaces the usage of this with |response()| calls. There was only one place where |m_response| was updated in the subclasses of Resource. This was in |ImageResource::onePartInMultipartReceived| and replaced with |setResponse()|. |setResponse()| updates not only |m_response| but also |m_cacheHandler|. Calling |setReponse()| is more appropriate for caching of a response which is multipart and fetched from ServiceWorker. BUG=n/a TEST=webkit_unit_tests --gtest_filter=ImageResourceTest.* Committed: https://crrev.com/5654f67165722ecac55bf646fd3821fc4f354b5c Cr-Commit-Position: refs/heads/master@{#408399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
hajimehoshi
PTAL
4 years, 4 months ago (2016-07-28 10:26:59 UTC) #2
Mike West
LGTM if the bots are happy.
4 years, 4 months ago (2016-07-28 10:55:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183323005/1
4 years, 4 months ago (2016-07-28 15:35:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 15:41:45 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 15:44:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5654f67165722ecac55bf646fd3821fc4f354b5c
Cr-Commit-Position: refs/heads/master@{#408399}

Powered by Google App Engine
This is Rietveld 408576698