Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 21833005: Fix PPAPI TestCase so individual tests can be run more than once. (Closed)

Created:
7 years, 4 months ago by bbudge
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix PPAPI TestCase so individual tests can be run more than once. When tests are run multiple times (e.g. to test callback types), only the first invocation runs. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215776

Patch Set 1 #

Patch Set 2 : Fix exposed test failure in FileIO. #

Patch Set 3 : Robustify. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M ppapi/tests/test_case.h View 1 1 chunk +13 lines, -10 lines 0 comments Download
M ppapi/tests/test_case.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M ppapi/tests/test_file_io.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bbudge
This can't be landed directly. It causes some new test configurations to run and some ...
7 years, 4 months ago (2013-08-03 00:53:53 UTC) #1
dmichael (off chromium)
Ugh, sorry, nice catch. This part lgtm... let me know when you have the fixes. ...
7 years, 4 months ago (2013-08-03 03:46:06 UTC) #2
bbudge
On 2013/08/03 03:46:06, dmichael wrote: > Ugh, sorry, nice catch. This part lgtm... let me ...
7 years, 4 months ago (2013-08-03 05:26:05 UTC) #3
bbudge
Move the Delete to before Open to make the test handle more bad cases.
7 years, 4 months ago (2013-08-05 20:59:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/21833005/18001
7 years, 4 months ago (2013-08-05 21:23:36 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 03:07:15 UTC) #6
Message was sent while issue was closed.
Change committed as 215776

Powered by Google App Engine
This is Rietveld 408576698